Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(waitForFunction): handle predicate that throws #2488

Merged
merged 1 commit into from
Jun 8, 2020
Merged

fix(waitForFunction): handle predicate that throws #2488

merged 1 commit into from
Jun 8, 2020

Commits on Jun 8, 2020

  1. fix(waitForFunction): handle predicate that throws 

    Currently, we fail when the predicate throws on the first call,
and timeout when it fails on any other call.

There are two possible ways to handle throwing predicates:
- Fail waitForFunction if predicate throws once. This is good
  since it gives you the error faster.
- Tolerate predicate exceptions. This is good because you do
  not have to worry about non-initialized state during load.

This change implements the former.
    @dgozman
    dgozman committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    bc8f9e8 View commit details
    Browse the repository at this point in the history