Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browser(webkit): expose worker's owner frame #694

Merged
merged 1 commit into from
Jan 29, 2020
Merged

browser(webkit): expose worker's owner frame #694

merged 1 commit into from
Jan 29, 2020

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Jan 28, 2020 •
edited
Loading

@dgozman dgozman mentioned this pull request Jan 28, 2020
Closed
@pavelfeldman
Copy link
Member

How do we deal with the workers created by workers?

@dgozman
Copy link
Contributor Author

dgozman commented Jan 28, 2020

How do we deal with the workers created by workers?

Good point. Right now, we don't report them in WebKit at all, so this change seems fine. Long term, I guess we'll have parentFrame and parentWorker methods in the api.

@dgozman dgozman merged commit 7ea4110 into microsoft:master Jan 29, 2020
@dgozman dgozman deleted the wk-worker-frameid branch January 29, 2020 19:57
sand4rt pushed a commit to sand4rt/playwright that referenced this pull request Dec 21, 2022
@debs-obrien
docs: add new talk (microsoft#694)
8ffb060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgozman @pavelfeldman