Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate potential perf improvements in colour-science codebase #9109

Closed
erictraut opened this issue Sep 29, 2024 · 3 comments
Closed

Investigate potential perf improvements in colour-science codebase #9109

erictraut opened this issue Sep 29, 2024 · 3 comments
Labels
addressed in next version Issue is fixed and will appear in next published version enhancement request New feature or request

Comments

@erictraut
Copy link
Collaborator

See this comment.

On initial inspection, it appears that the file colour/characterisation/datasets/colour_checkers/chromaticity_coordinates.py is taking excessive time (55sec on a fast machine) to type check. Other files are also taking much longer than I'd expect.

55124ms: /characterisation/datasets/colour_checkers/chromaticity_coordinates.py
7455ms: /notation/datasets/munsell/all.py
3773ms: /notation/datasets/munsell/real.py
3693ms: /geometry/tests/test_vertices.py
3103ms: /models/rgb/tests/test_rgb_colourspace.py
2597ms: /utilities/tests/test_array.py
2117ms: /io/luts/tests/test_lut.py
1958ms: /models/tests/test_cie_luv.py
1625ms: /corresponding/tests/test_prediction.py
1524ms: /continuous/tests/test_multi_signal.py
1262ms: /notation/tests/test_munsell.py
1255ms: /notation/datasets/munsell/experimental.py
1252ms: /quality/tests/test_cqs.py
1240ms: /models/tests/test_cie_xyy.py
1158ms: /geometry/tests/test_primitives.py
1156ms: /characterisation/tests/test_aces_it.py
1089ms: /algebra/tests/test_common.py
1077ms: /models/rgb/tests/test_ictcp.py
1037ms: /models/tests/test_cie_ucs.py
1026ms: /colorimetry/tests/test_tristimulus_values.py
1009ms: /models/rgb/tests/test_derivation.py
@erictraut erictraut added the enhancement request New feature or request label Sep 29, 2024
erictraut added a commit that referenced this issue Sep 30, 2024
…col matching for complex, nested protocols. This addresses #9109.
erictraut added a commit that referenced this issue Sep 30, 2024
…col matching for complex, nested protocols. This addresses #9109. (#9115)
@erictraut erictraut added the addressed in next version Issue is fixed and will appear in next published version label Sep 30, 2024
@erictraut
Copy link
Collaborator Author

This is addressed in pyright 1.1.383.

@erictraut erictraut reopened this Oct 7, 2024
@erictraut erictraut removed the addressed in next version Issue is fixed and will appear in next published version label Oct 7, 2024
@erictraut
Copy link
Collaborator Author

I needed to back out the performance optimization because it caused a regression in protocol matching. I'll need to investigate other ways to address this.

erictraut added a commit that referenced this issue Oct 8, 2024
erictraut added a commit that referenced this issue Oct 8, 2024
@erictraut erictraut added the addressed in next version Issue is fixed and will appear in next published version label Oct 8, 2024
@erictraut
Copy link
Collaborator Author

This is addressed in pyright 1.1.384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addressed in next version Issue is fixed and will appear in next published version enhancement request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant