-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate potential perf improvements in colour-science
codebase
#9109
Labels
addressed in next version
Issue is fixed and will appear in next published version
enhancement request
New feature or request
Comments
erictraut
added a commit
that referenced
this issue
Sep 30, 2024
…col matching for complex, nested protocols. This addresses #9109.
erictraut
added
the
addressed in next version
Issue is fixed and will appear in next published version
label
Sep 30, 2024
This is addressed in pyright 1.1.383. |
erictraut
removed
the
addressed in next version
Issue is fixed and will appear in next published version
label
Oct 7, 2024
I needed to back out the performance optimization because it caused a regression in protocol matching. I'll need to investigate other ways to address this. |
erictraut
added a commit
that referenced
this issue
Oct 8, 2024
…ursive protocols. This addresses #9109.
erictraut
added
the
addressed in next version
Issue is fixed and will appear in next published version
label
Oct 8, 2024
This is addressed in pyright 1.1.384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
addressed in next version
Issue is fixed and will appear in next published version
enhancement request
New feature or request
See this comment.
On initial inspection, it appears that the file
colour/characterisation/datasets/colour_checkers/chromaticity_coordinates.py
is taking excessive time (55sec on a fast machine) to type check. Other files are also taking much longer than I'd expect.The text was updated successfully, but these errors were encountered: