Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version conflict for security bump #1734

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

billti
Copy link
Member

@billti billti commented Jul 11, 2024

There was some overly strict version locking that was causing the dependabot bump in #1730 to fail to build. This loosens the version restriction and updates to compatible versions of many packages (including 'ws' which should resolve the dependabot issue).

Copy link

Benchmark for 175e1b8

Click to view benchmark
Test Base PR %
Array append evaluation 332.3±2.82µs 332.2±3.08µs -0.03%
Array literal evaluation 168.6±1.15µs 186.1±3.27µs +10.38%
Array update evaluation 410.3±2.48µs 410.9±1.45µs +0.15%
Core + Standard library compilation 21.6±0.37ms 22.0±0.40ms +1.85%
Deutsch-Jozsa evaluation 4.8±0.15ms 4.8±0.05ms 0.00%
Large file parity evaluation 34.1±0.18ms 34.3±0.67ms +0.59%
Large input file compilation 12.4±0.16ms 12.6±0.19ms +1.61%
Large input file compilation (interpreter) 51.0±1.67ms 50.7±1.43ms -0.59%
Large nested iteration 32.0±0.20ms 32.3±0.42ms +0.94%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1565.9±37.26µs 1572.5±57.94µs +0.42%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.9±0.35ms 7.9±0.19ms 0.00%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1434.8±69.07µs 1446.3±82.57µs +0.80%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 27.9±0.21ms 28.3±1.49ms +1.43%
Teleport evaluation 89.8±3.07µs 91.3±2.93µs +1.67%

@billti billti enabled auto-merge July 11, 2024 23:52
@billti billti added this pull request to the merge queue Jul 12, 2024
@billti billti removed this pull request from the merge queue due to a manual request Jul 12, 2024
@billti billti added this pull request to the merge queue Jul 12, 2024
Merged via the queue into main with commit 4cf5f6a Jul 12, 2024
19 checks passed
@billti billti deleted the billti/jupyterlab-deps-upgrade branch July 12, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants