Refactor evaluator to reduce stack use #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Keeping in draft while I try to work through some further refactoring. |
swernli
force-pushed
the
swernli/stackless
branch
from
154e96e
to
370ceb4
Compare
swernli
force-pushed
the
swernli/stackless
branch
2 times, most recently
from
e5ee176
to
db8002b
Compare
swernli
force-pushed
the
swernli/stackless
branch
from
db8002b
to
8866a89
Compare
bamarsha
reviewed
May 16, 2023
bamarsha
reviewed
May 16, 2023
bamarsha
reviewed
May 17, 2023
swernli
commented
May 17, 2023
This change adds some benchmarking of the evaluator using the checked in Teleportation and Deutsch-Jozsa samples.
swernli
force-pushed
the
swernli/stackless
branch
from
e89adcc
to
f5414dd
Compare
bamarsha
reviewed
May 17, 2023
bamarsha
approved these changes
May 17, 2023
DmitryVasilevsky
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the evaluator to use a "stackless" design where the stack is tracked manually via data structures instead of via literal progam stack. This allows for better avoidance of stack overflow at the cost of some performance. To help track performance characteristics, this also introduces benchmarks based on evaluating some programs from the samples folder.