[rush] Replace the AWS SDK packages with the S3 REST API. #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
apostolisms,
D4N14L,
halfnibble,
octogonz,
patmill and
sachinjoseph
as code owners
|
@raihle - you're more experienced with S3 and the Rush S3 code than I am. Would you mind taking a look through this PR? |
octogonz
reviewed
Mar 16, 2021
octogonz
reviewed
Mar 16, 2021
octogonz
reviewed
Mar 16, 2021
octogonz
reviewed
Mar 16, 2021
octogonz
reviewed
Mar 16, 2021
octogonz
reviewed
Mar 16, 2021
octogonz
reviewed
Mar 16, 2021
octogonz
approved these changes
Mar 16, 2021
|
@iclanton thank you so much for doing this work! |
This was referenced Mar 17, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #2547 by removing the AWS npm packages as dependencies of Rush and replaces them with use of the S3 REST API.
How it was tested
Tested by building the rushstack repo with a S3 bucket configured as the cloud cache provider.