Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] rush change -v on shallow checkout is confusing #3805

Closed
elliot-nelson opened this issue Dec 2, 2022 · 2 comments
Closed

[rush] rush change -v on shallow checkout is confusing #3805

elliot-nelson opened this issue Dec 2, 2022 · 2 comments

Comments

@elliot-nelson
Copy link
Collaborator

Summary

By default, GitHub Actions performs a shallow clone (fetch depth1).

This means it is easy to get caught by an error when running rush change -v in a new pipeline. However, the error message is confusing and doesn't clearly indicate that the fetch depth could be the issue.

Repro steps

Run rush change -v in a shallow clone.

Standard questions

Please answer these questions to help us investigate your issue more quickly:

Question Answer
@microsoft/rush globally installed version?
rushVersion from rush.json?
useWorkspaces from rush.json?
Operating system?
Would you consider contributing a PR?
Node.js version (node -v)?
@iclanton
Copy link
Member

iclanton commented Dec 5, 2022

What is the error? I guess if there is a Git error during any rush change operation, we could look at the fetch depth and then present a more useful error message. Would you be interested in putting that together?

@elliot-nelson
Copy link
Collaborator Author

Fixed by #3668 - at the time we didn't have this update, I think it is now much more direct!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants