Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-extractor] Rename "API Review File" to "API Report File" #1213

Merged
merged 5 commits into from
Apr 8, 2019

Conversation

octogonz
Copy link
Collaborator

@octogonz octogonz commented Apr 8, 2019

As of AE7 we're now referring to the .api.md file everywhere as an "API Report File" (whereas API Extractor 6 called it an "API Review File"). This PR fixes a bunch of inconsistent places, most notably the "addToApiReviewFile" setting in the api-extractor.json config file schema. (This is breaking change, but a somewhat rarely used setting.)

We still use the "API review" terminology for the actual review process. For example, the message still says "Please request an API review", and Rush's common/reviews folder name will still be standard. But the main point is that the .api.md file is often used instead for other workflows that are not formal API "reviews".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants