[api-extractor] Fix issue where API signatures were sometimes truncated #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… extends B<{c: C}> { }" to "interface A extends B<{" because it stopped at the first "{" encountered, even if it was not an immediate child in the AST
|
Awesome! Will test this afternoon |
|
Tested! Looks great. The broken signatures are fixed and no other signatures appear to be broken from these changes. |
|
Thanks @natalieethell |
iclanton
approved these changes
Apr 30, 2019
This was referenced Sep 16, 2021
This was referenced Nov 4, 2022
This was referenced Dec 25, 2022
This was referenced Nov 29, 2023
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1249
@natalieethell could you test this and confirm that (1) the broken signatures are fixed, and (2) no other signatures appear to be broken? (You could simply diff your before/after .api.json files.) Thanks!