[api-extractor] support .d.mts and .d.cts files #4023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ds300
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
|
👋 friendly ping @dmichon-msft, is there anything we can do to get this merged in? |
dmichon-msft
approved these changes
Jun 15, 2023
|
cc ... @iclanton? Is there someone we can bug about this? 🙂 |
|
🙌 thanks! |
Qjuh
pushed a commit
to discordjs/rushstack
that referenced
this pull request
Nov 7, 2023
[api-extractor] support .d.mts and .d.cts files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TypeScript supports emitting and loading typings with
.d.ctsand.d.mtsfile extensions. We published a package which uses these extensions for its typings file, but it broke our api-extractor usage so we applied this patch.Details
This was the only place I found that specifically hard-coded the
.d.tsrequirement.How it was tested
Sorry I don't have time to dig into how you're doing testing in this repo.
Impacted documentation
I don't think this affects any docs, or needs to be explicitly document itself.