Skip to content

Commit

Permalink
Users/segomez/revert mono libraries (#381)
Browse files Browse the repository at this point in the history
* Revert "[docs] remove unsupported ARM notice for Homebrew installation (#378)"

This reverts commit 1cec62d.

* Revert "Don't warn on NU5104 for Mono.Unix Package (#374)"

This reverts commit c2f2f06.

* Revert "Migrate from Mono.Posix.NETStandard to Mono.Unix (#346)"

This reverts commit 7bd0019.

---------

Co-authored-by: Sebastian Gomez <[email protected]>
  • Loading branch information
sebasgomez238 and sebasgomez238 authored Sep 19, 2023
1 parent 2aa42f1 commit f2b3a12
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,11 @@ dotnet_diagnostic.SA1623.severity = none
# https:/dotnet/roslyn-analyzers/issues/6852
dotnet_diagnostic.CA1859.severity = none

# NU5104: A stable release of a package should not have a prerelease dependency
# Justification: The Mono.Unix package that allows our tool to be built on ARM is labeled as 7.1.0-final.1.21458.1 which is detected as a prerelease dependency.
# https://learn.microsoft.com/en-us/nuget/reference/errors-and-warnings/nu5104
dotnet_diagnostic.NU5104.severity = none

##########################################
# Temporary rules
#
Expand Down
2 changes: 1 addition & 1 deletion Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="1.1.1" />
<PackageVersion Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.7.30" />
<PackageVersion Include="MinVer" Version="4.3.0" />
<PackageVersion Include="Mono.Unix" Version="7.1.0-final.1.21458.1" />
<PackageVersion Include="Mono.Posix.NETStandard" Version="1.0.0" />
<PackageVersion Include="Moq" Version="4.17.2" />
<PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
<PackageVersion Include="NuGet.Frameworks" Version="6.7.0" />
Expand Down
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ winget install Microsoft.SbomTool

##### Homebrew

> [!NOTE]
> This Formulae requires the `x86_64` architecture, ARM is not supported at this time. For details see [#223](https:/microsoft/sbom-tool/issues/223).
```bash
brew install sbom-tool
```
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Sbom.Common/Microsoft.Sbom.Common.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Mono.Unix" NoWarn="NU5104" />
<PackageReference Include="Mono.Posix.NETStandard" />
<PackageReference Include="Serilog.Sinks.Console" />
<PackageReference Include="System.IO.FileSystem.AccessControl" />
<PackageReference Include="System.Private.Uri" />
Expand Down

0 comments on commit f2b3a12

Please sign in to comment.