-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ILogger<T>
from Microsoft.Extensions.Logging
instead of ILogger
from Serilog
#284
Comments
We think this is already fixed, @sebasgomez238 the work item is to double-check that assumption. |
I think that some of this work was completed in #292. However, there are still a lot of use cases of EDIT: Actually, it depends. The work was completed to upgrade Component Detection and all the logger references there. Actually working on the rest of the code base isn't required, but using two different logger interfaces is slightly confusing. |
The SBOM tool uses Serilog's
ILogger
interface directly. Unfortunately, Component Detection expects theILogger<T>
interface fromMicrosoft.Extensions.Logging
and uses theSerilog.Extensions.Logging
package to provide an implementation.In our research, using the
Microsoft.Extensions.Logging
logging API, and plugging in different logging frameworks (like Serilog) was the recommended approach.The text was updated successfully, but these errors were encountered: