Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh SbomConfigProvider when config values change #475

Closed
wants to merge 1 commit into from

Conversation

micyunmsft
Copy link
Contributor

Currently SbomConfigProvider doesn't pick up updated config values when the global Configuration changes.

@micyunmsft micyunmsft requested a review from a team as a code owner January 10, 2024 18:46
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (d251a5f) 59.78% compared to head (293f1d8) 59.76%.

Files Patch % Lines
...m.Api/Manifest/Configuration/SbomConfigProvider.cs 16.66% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #475      +/-   ##
==========================================
- Coverage   59.78%   59.76%   -0.02%     
==========================================
  Files         248      248              
  Lines        7566     7575       +9     
  Branches      901      901              
==========================================
+ Hits         4523     4527       +4     
- Misses       2631     2635       +4     
- Partials      412      413       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlperkins
Copy link
Contributor

Closing in favor of the type of fix described in #480.

@jlperkins jlperkins closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants