Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net Gemini Connector - Allow Version Selection and Base Url overriding. #5659

Closed
RogerBarreto opened this issue Mar 26, 2024 · 1 comment · Fixed by #5750
Closed

.Net Gemini Connector - Allow Version Selection and Base Url overriding. #5659

RogerBarreto opened this issue Mar 26, 2024 · 1 comment · Fixed by #5750
Assignees
@RogerBarreto
Labels
.NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@RogerBarreto
Copy link
Member

The v1beta part of the URL is going to change and there may be times when multiple versions will be supported at the same time.

We should have:

A central place where the default API version is set
We should consider if we want to allow developers to change this. We do allow this in Azure OpenAI. It's a risky thing for a developer to do but that doesn't mean someone may have a good reason and we don't necessarily want to block them.

Basically when using AddGeminiChatCompletion we should be able to specify the target version in the service Settings, this will be adjusting the correct Uri of the client v1beta or v1, etc.

Not very sure about be able to override the endpoint as I don't see a potential mock or virtualization of GCP to be targetted (edge case).
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code triage labels Mar 26, 2024
@RogerBarreto RogerBarreto mentioned this issue Mar 26, 2024
Merged
4 tasks
@markwallace-microsoft markwallace-microsoft added sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) and removed triage labels Mar 26, 2024
@matthewbolanos matthewbolanos added sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) and removed sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) labels Mar 26, 2024
@Krzysztof318 Krzysztof318 mentioned this issue Apr 3, 2024
Merged
4 tasks
@Krzysztof318
Copy link
Contributor

Krzysztof318 commented Apr 3, 2024 •
edited
Loading

I think also that creating custom endpoint overload doesn't make sense.

github-merge-queue bot pushed a commit that referenced this issue Apr 23, 2024
@Krzysztof318 @RogerBarreto
.Net: Google connector API version selection (#5750)
875477e 
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

Closes #5659

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

The update introduces support for different versions of the Google API
in various services and clients. A new enum, 'GoogleApiVersion', has
been added to represent stable and beta versions of the Google API.
Affected classes have been updated to accept this new parameter, and use
its value when constructing API endpoints.

GoogleAI endpoints currently support only BETA.

cc: @RogerBarreto 

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https:/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https:/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Roger Barreto <[email protected]>
LudoCorporateShark pushed a commit to LudoCorporateShark/semantic-kernel that referenced this issue Aug 25, 2024
@Krzysztof318 @RogerBarreto
.Net: Google connector API version selection (microsoft#5750)
1f3d3d9 
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

Closes microsoft#5659

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

The update introduces support for different versions of the Google API
in various services and clients. A new enum, 'GoogleApiVersion', has
been added to represent stable and beta versions of the Google API.
Affected classes have been updated to accept this new parameter, and use
its value when constructing API endpoints.

GoogleAI endpoints currently support only BETA.

cc: @RogerBarreto 

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https:/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https:/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Roger Barreto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RogerBarreto RogerBarreto

Labels
.NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Semantic Kernel
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

.Net: Google connector API version selection Krzysztof318/semantic-kernel
4 participants
@matthewbolanos @RogerBarreto @Krzysztof318 @markwallace-microsoft