Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Update to Azure.AI.OpenAI version 1.0.0-beta.6 #2090

Merged
merged 3 commits into from
Jul 20, 2023
Merged

.Net: Update to Azure.AI.OpenAI version 1.0.0-beta.6 #2090

merged 3 commits into from
Jul 20, 2023

Conversation

anthonypuppo
Copy link
Contributor

@anthonypuppo anthonypuppo commented Jul 20, 2023

Motivation and Context

Utilize the latest version of the Azure.AI.OpenAI package. This provides support for the latest Azure OpenAI REST API versions (including function calling!) and fixes a minor regression.

Fixes #2089

Description

Update to Azure.AI.OpenAI version 1.0.0-beta.6 and fix minor regression.

Contribution Checklist

@anthonypuppo anthonypuppo requested a review from a team as a code owner July 20, 2023 13:34
@shawncal shawncal added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Jul 20, 2023
@shawncal shawncal changed the title Update to Azure.AI.OpenAI version 1.0.0-beta.6 .Net: Update to Azure.AI.OpenAI version 1.0.0-beta.6 Jul 20, 2023
@shawncal shawncal added this pull request to the merge queue Jul 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 20, 2023
@shawncal
Copy link
Member

shawncal commented Jul 20, 2023

Looks like we've got an integration test break with this update:
SemanticKernel.IntegrationTests.Planning.SequentialPlanner.SequentialPlannerTests.CreatePlanFunctionFlowAsync(useChatModel: True, prompt: "Write a joke and send it in an e-mail to Kai.", expectedFunction: "SendEmail", expectedSkill: "GLOBAL_FUNCTIONS")

   -------- Azure.RequestFailedException : 'System' is not one of ['system', 'assistant', 'user'] - 'messages.0.role'
   Status: 400 (model_error)

=== SOLUTION =================================================================

@anthonypuppo Can you please update the strings ("System", "Assistant", "User") to lowercase in this file, and push an update to this PR?
dotnet\src\SemanticKernel.Abstractions\AI\ChatCompletion\AuthorRole.cs

Copy link
Member

@shawncal shawncal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@craigomatic
Copy link
Contributor

Related to #1450

@anthonypuppo
Copy link
Contributor Author

Looks like we've got an integration test break with this update: SemanticKernel.IntegrationTests.Planning.SequentialPlanner.SequentialPlannerTests.CreatePlanFunctionFlowAsync(useChatModel: True, prompt: "Write a joke and send it in an e-mail to Kai.", expectedFunction: "SendEmail", expectedSkill: "GLOBAL_FUNCTIONS")

   -------- Azure.RequestFailedException : 'System' is not one of ['system', 'assistant', 'user'] - 'messages.0.role'
   Status: 400 (model_error)

=== SOLUTION =================================================================

@anthonypuppo Can you please update the strings ("System", "Assistant", "User") to lowercase in this file, and push an update to this PR? dotnet\src\SemanticKernel.Abstractions\AI\ChatCompletion\AuthorRole.cs

Done.

@shawncal shawncal enabled auto-merge July 20, 2023 22:34
@shawncal shawncal added this pull request to the merge queue Jul 20, 2023
Merged via the queue into microsoft:main with commit dbb7cb9 Jul 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET: Package Azure.AI.OpenAI beta 6 release breaking change
3 participants