Copilot Chat: Show live updates from ChatSkill #2103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit changes the ChatSkill to broadcast messages of its execution to the frontend. this is useful in reducing the effect of the latency incurred when generating a response.
dehoward
added
PR: ready for review
TaoChenOSU
previously approved these changes
Jul 20, 2023
samples/apps/copilot-chat-app/webapi/CopilotChat/Controllers/ChatController.cs
Outdated
Show resolved
Hide resolved
glahaye
previously approved these changes
Jul 21, 2023
| message = '1 user is typing'; | ||
| let message = botResponseStatus; | ||
| if (numberOfUsersTyping === 1) { | ||
| message = message ? `${message} and 1 user is typing` : '1 user is typing'; |
There was a problem hiding this comment.
Nit: instead of saying "1 user", maybe write "a user"?
Suggested change
| message = message ? `${message} and 1 user is typing` : '1 user is typing'; | |
| message = message ? `${message} and a user is typing` : 'A user is typing'; |
TaoChenOSU
previously approved these changes
Jul 21, 2023
4 tasks
|
moved to microsoft/chat-copilot#14. |
github-merge-queue bot
pushed a commit
to microsoft/chat-copilot
that referenced
this pull request
Jul 22, 2023
Original PR: microsoft/semantic-kernel#2103. ------------------- ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> showing the current status of execution helps dampen the effect of the response latency. ### Description - updates `ChatSkill` to use the `MessageRelayHub` for broadcasting status updates - changes `botIsTyping` to `botResponseStatus` in `ChatState`  <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https:/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https:/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#dev-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
showing the current status of execution helps dampen the effect of the response latency.
Description
ChatSkillto use theMessageRelayHubfor broadcasting status updatesbotIsTypingtobotResponseStatusinChatStateContribution Checklist