.Net: Template Engine interface cleanup #2108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Primary change: removing some methods from the ITemplateEngine interface, to reduce the surface area and make it less taxing for other TemplateEngine implementations. The methods that have been removed are still there in our implementation -- they've just been marked internal.
Also making some property fields nullable:
Description
andDefaultValue
. These beingnull
implies they're never set, whereas a default value of "empty string" may be a valid implementation choice in a rendered prompt.There's more to be done here, but this is an easy first pass.
Contribution Checklist