Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Template Engine interface cleanup #2108

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

shawncal
Copy link
Member

Description

Primary change: removing some methods from the ITemplateEngine interface, to reduce the surface area and make it less taxing for other TemplateEngine implementations. The methods that have been removed are still there in our implementation -- they've just been marked internal.

Also making some property fields nullable: Description and DefaultValue. These being null implies they're never set, whereas a default value of "empty string" may be a valid implementation choice in a rendered prompt.

There's more to be done here, but this is an easy first pass.

Contribution Checklist

@shawncal shawncal added the .NET Issue or Pull requests regarding .NET code label Jul 21, 2023
@shawncal shawncal requested a review from a team as a code owner July 21, 2023 02:18
@shawncal shawncal added kernel Issues or pull requests impacting the core kernel kernel.core labels Jul 21, 2023
@dmytrostruk dmytrostruk added the PR: ready for review All feedback addressed, ready for reviews label Jul 21, 2023
@shawncal shawncal enabled auto-merge July 21, 2023 22:24
@shawncal shawncal added this pull request to the merge queue Jul 21, 2023
Merged via the queue into microsoft:main with commit 264e716 Jul 21, 2023
12 checks passed
@shawncal shawncal deleted the template-engine-interface branch July 21, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code PR: ready for review All feedback addressed, ready for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants