.Net: Fixed ReSharper/Rider errors to be compliant with dotnet formatting settings #5862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
RogerBarreto
approved these changes
Apr 23, 2024
westey-m
approved these changes
Apr 23, 2024
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
…ting settings (microsoft#5862) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Related to microsoft#4653 Before changes, VS studio with resharper or Rider showed many errors and warnings. But without resharper, VS studio shows 0 errors and 0 warnings like on screenshot.  For Rider/Resharper (errors only):  ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Now, after changes in .editorconfig for these developers which are using resharper/rider will show only resharper warnings, errors are empty like in VS studio.  All disabled or changed to suggestion/warning rules were visible as errors before. I also was forced to update the`SK-dotnet.sln.DotSettings` file due to the new resharper version 2024.1 ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https:/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https:/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Mark Wallace <[email protected]> Co-authored-by: Roger Barreto <[email protected]>
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
…ting settings (microsoft#5862) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Related to microsoft#4653 Before changes, VS studio with resharper or Rider showed many errors and warnings. But without resharper, VS studio shows 0 errors and 0 warnings like on screenshot.  For Rider/Resharper (errors only):  ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Now, after changes in .editorconfig for these developers which are using resharper/rider will show only resharper warnings, errors are empty like in VS studio.  All disabled or changed to suggestion/warning rules were visible as errors before. I also was forced to update the`SK-dotnet.sln.DotSettings` file due to the new resharper version 2024.1 ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https:/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https:/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Mark Wallace <[email protected]> Co-authored-by: Roger Barreto <[email protected]>
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
…ting settings (microsoft#5862) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Related to microsoft#4653 Before changes, VS studio with resharper or Rider showed many errors and warnings. But without resharper, VS studio shows 0 errors and 0 warnings like on screenshot.  For Rider/Resharper (errors only):  ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Now, after changes in .editorconfig for these developers which are using resharper/rider will show only resharper warnings, errors are empty like in VS studio.  All disabled or changed to suggestion/warning rules were visible as errors before. I also was forced to update the`SK-dotnet.sln.DotSettings` file due to the new resharper version 2024.1 ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https:/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https:/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Mark Wallace <[email protected]> Co-authored-by: Roger Barreto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Related to #4653
Before changes, VS studio with resharper or Rider showed many errors and warnings.
But without resharper, VS studio shows 0 errors and 0 warnings like on screenshot.
For Rider/Resharper (errors only):
Description
Now, after changes in .editorconfig for these developers which are using resharper/rider will show only resharper warnings, errors are empty like in VS studio.
All disabled or changed to suggestion/warning rules were visible as errors before.
I also was forced to update the
SK-dotnet.sln.DotSettingsfile due to the new resharper version 2024.1Contribution Checklist