.Net: Refactor PromptyKernelExtensions.CreateFunctionFromPrompty #6107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
dmytrostruk
approved these changes
May 2, 2024
dotnet/src/Functions/Functions.Prompty/Extensions/PromptyKernelExtensions.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
May 2, 2024
dotnet/src/Functions/Functions.Prompty/Extensions/PromptyKernelExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Functions/Functions.Prompty/Extensions/PromptyKernelExtensions.cs
Show resolved
Hide resolved
dotnet/src/Functions/Functions.Prompty/Extensions/PromptyKernelExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Functions/Functions.Prompty/Extensions/PromptyKernelExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Functions/Functions.Prompty/Extensions/PromptyKernelExtensions.cs
Show resolved
Hide resolved
…lExtensions.cs Co-authored-by: Stephen Toub <[email protected]>
…lExtensions.cs Co-authored-by: Stephen Toub <[email protected]>
…lExtensions.cs Co-authored-by: Dmytro Struk <[email protected]>
markwallace-microsoft
merged commit 513f0b0
into
microsoft:feature-prompty
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
PromptyKernelExtensions.CreateFunctionFromPromptyThe second parameter is a file path to a prompty file. This should be changed to the prompty text. Doing this will allow developers to be responsible for loading the prompty file e.g. could be a file or an embedded resource or a database record...
Description
Contribution Checklist