Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solarized colors dropping spaces, foreground gray seems wrong #1233

Closed
zadjii-msft opened this issue Jun 12, 2019 · 1 comment
Closed

Solarized colors dropping spaces, foreground gray seems wrong #1233

zadjii-msft opened this issue Jun 12, 2019 · 1 comment
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Milestone
Terminal v1.0

Comments

@zadjii-msft
Copy link
Member

From MSFT:21253231

It seems like Terminal Preview does something weird with color 7... mapping it (I think) to the 'foreground' color in the scheme. This is confusing, because the default scheme (Campbell) has a different color for 'foreground' than color 7.e.g., run "color 7f" and "color f7" commands in Terminal Preview. In both cases, the text color is lighter than the background... but that shouldn't be possible.
@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Product-Terminal The new Windows Terminal. labels Jun 12, 2019
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Jun 12, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 12, 2019
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 12, 2019
@DHowett-MSFT
Copy link
Contributor

This is a duplicate of #293 actually!

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Jun 12, 2019
@DHowett-MSFT DHowett-MSFT added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Jun 12, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
Terminal v1.0
Development

No branches or pull requests
2 participants
@DHowett-MSFT @zadjii-msft