Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust selection when resizing window #1368

Closed
mcpiroman opened this issue Jun 21, 2019 · 3 comments
Closed

Adjust selection when resizing window #1368

mcpiroman opened this issue Jun 21, 2019 · 3 comments
Assignees
@carlos-zamora
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal v2.0

Comments

@mcpiroman
Copy link
Contributor

Environment

commit 0846464

Steps to reproduce

  1. Start new terminal session
  2. Have some long line that fits viewport, e.g. write a 40 times
  3. Select text in that line
  4. Gradually shrink window horizontally (reduce width)

Expected behavior

When selected text gets wrapped or moves downward (due to previous lines being wrapped), selection should follow.

Actual behavior

Selection stays at one line and doesn't move.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 21, 2019
@mcpiroman mcpiroman mentioned this issue Jun 22, 2019
Closed
@DHowett-MSFT DHowett-MSFT added this to the Terminal Backlog milestone Jun 24, 2019
@DHowett-MSFT DHowett-MSFT added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Jun 24, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 24, 2019
@DHowett-MSFT DHowett-MSFT added Needs-Tag-Fix Doesn't match tag requirements and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 24, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 24, 2019
@mcpiroman mcpiroman mentioned this issue Jul 4, 2019
Closed
@mcpiroman mcpiroman mentioned this issue Jul 12, 2019
Closed
@carlos-zamora
Copy link
Member

At some point, I changed the behavior to be that selection clears on resize.

I'm treating this issue now as a feature request for adjusting the selection when resizing.

@carlos-zamora carlos-zamora changed the title Selection not properly adjusted when shrinking window Adjust selection when resizing window May 12, 2020
@carlos-zamora carlos-zamora added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. and removed Issue-Task It's a feature request, but it doesn't really need a major design. labels May 12, 2020
@carlos-zamora carlos-zamora self-assigned this May 12, 2020
@DHowett-MSFT
Copy link
Contributor

I'm not sure the value in keeping the selection during resize. Why should we do it?

@carlos-zamora
Copy link
Member

Actually, yeah. I just realized this issue was submitted almost a year ago haha. The issues with maintaining the selection on a resize is that (as noted by this issue) the selection anchors can't be guaranteed to point to the same text once text wraps in the buffer. It's a lot of extra work and not really worth it, considering that the user can easily just do another selection.

I'll close this out, for now, until proven otherwise that there's value in keeping a selection after a resize.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 13, 2020
@zadjii-msft zadjii-msft mentioned this issue Aug 10, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v2.0
Development

No branches or pull requests
3 participants
@carlos-zamora @DHowett-MSFT @mcpiroman