-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Canary]: Tab tear-off leads to crash #17032
Comments
In debug build on |
Hmm, this is just a hunch, and I apologize for your SSD 😣, but could you try cleaning the entire solution and building it again? Some of us had this issue happen before and back then it could be resolved with a clean build. My suspicion is that the build system doesn't properly invalidate some compiled objects which results in mismatched vtables. |
@lhecker Thanks for the info. I'll try doing a clean build next time. I'm also curious why Canary might crash on tab tear-off 🤔 |
FWIW I can repro the tear-off crash on my own canary 21.991 (and after upgrading, my 21.1011) here as well. So, it's definitely not just a clean build problem. |
Closes: #17032 We were wrongly calling the Ctor of CommandPalette which led to the creation of an uninitialized winrt command palette object, and then OnCreateAutomationPeer() was called on that. This seems to be the cause of #17032. ## Validation Steps Performed - Open WT. - Try to tear off a tab out of the tab headers view. - WT doesn't crash.
Windows Terminal version
1.21.991.0
Windows build number
10.0.22631.0
Other Software
No response
Steps to reproduce
Expected Behavior
The tab is opened in a new WT window.
Actual Behavior
WT crashes.
The text was updated successfully, but these errors were encountered: