Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using "Duplicate tab" on the right-click context menu causes terminal to crash #17075

Closed
carlos-zamora opened this issue Apr 16, 2024 · 0 comments · Fixed by #17110
Closed

Using "Duplicate tab" on the right-click context menu causes terminal to crash #17075

carlos-zamora opened this issue Apr 16, 2024 · 0 comments · Fixed by #17110
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Severity-Crash Crashes are real bad news.
Milestone
Terminal v1.21

Comments

@carlos-zamora
Copy link
Member

carlos-zamora commented Apr 16, 2024 •
edited by zadjii-msft
Loading

v1.21.1011.0

image

const auto& paneType{ contentArgs.Type() };

you better believe, contentArgs is null
@carlos-zamora carlos-zamora added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Severity-Crash Crashes are real bad news. Product-Terminal The new Windows Terminal. labels Apr 16, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 16, 2024
@carlos-zamora carlos-zamora changed the title Using "Duplicate tab" on the right-click context menu causes terminal to crash. Using "Duplicate tab" on the right-click context menu causes terminal to crash Apr 16, 2024
@zadjii-msft zadjii-msft added the Severity-Blocking We won't ship a release like this! No-siree. label Apr 16, 2024
@zadjii-msft zadjii-msft mentioned this issue Apr 16, 2024
Closed
@zadjii-msft zadjii-msft added this to the Terminal v1.21 milestone Apr 16, 2024
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 17, 2024
zadjii-msft added a commit that referenced this issue Apr 23, 2024
@zadjii-msft
Don't explode when duplicating a pane
7abb15f 
I forgot to check here if the `INewContentArgs` were null or not. Pretty dumb mistake honestly.

Closes #17075
Closes #17076
zadjii-msft added a commit that referenced this issue Apr 23, 2024
@zadjii-msft
Don't explode when duplicating a pane
e81828e 
I forgot to check here if the `INewContentArgs` were null or not. Pretty dumb mistake honestly.

Closes #17075
Closes #17076
@zadjii-msft zadjii-msft mentioned this issue Apr 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 23, 2024
@zadjii-msft
Don't explode when duplicating a pane (#17110)
87a9f72 
I forgot to check here if the `INewContentArgs` were null or not. Pretty
dumb mistake honestly.

Closes #17075
Closes #17076
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Severity-Crash Crashes are real bad news.
Projects
None yet
Milestone
Terminal v1.21
Development

Successfully merging a pull request may close this issue.

Don't explode when duplicating a pane microsoft/terminal
2 participants
@carlos-zamora @zadjii-msft