Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal closes when store tries to update #17385

Closed
jsberg-bnl opened this issue Jun 6, 2024 · 6 comments
Closed

Terminal closes when store tries to update #17385

jsberg-bnl opened this issue Jun 6, 2024 · 6 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@jsberg-bnl
Copy link

Windows Terminal version

1.20.11381.0

Windows build number

10.0.22631.0

Other Software

No response

Steps to reproduce

Terminal is in use. A terminal update becomes available in the Store, and App updates are set to automatic.

Expected Behavior

The terminal app would continue running, the update would happen at some point when terminal is not open.

Actual Behavior

Terminal closed.

@jsberg-bnl jsberg-bnl added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 6, 2024
Copy link

github-actions bot commented Jun 6, 2024

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@jsberg-bnl
Copy link
Author

Issue #3915 indicates this should be fixed, but it still seems to be a problem.

@microsoft microsoft deleted a comment from thug-shaker Jun 10, 2024
@zadjii-msft
Copy link
Member

Okay so this was added in #16250, in 1.20 preview. And the SDK version it was added to was 25381.1.230528-0554, though, I think that's just 10.0.22631.0 externally (waiting on confirmation)

But you're on v1.20.11381.0, which would have updated from v1.20.11271.0... unless of course you updated straight from a 1.19 build (without UpdateWhileInUse) to the 1.20 build with it. I suppose that's possible, though I'm not sure there's a log that would confirm that hypothesis...

@jsberg-bnl
Copy link
Author

I'm just updating automatically through the store (no choice, group policy), so I would have updated from whatever version was in the store previously. I had another update-caused crash not too long before, so I would assume I was at the latest store-available version when the update to 1.20.11381.0 happened.

@zadjii-msft
Copy link
Member

Just followed up with a contact on the Store team. Looks like Windows 11 builds 25399+ will be the first ones that actually have support for this. So Terminal is more than ready for it, but we need to wait for that to roll out broadly.

They also investigated backporting to earlier Windows versions, but that wasn't a possibility at this time. Alas, at least it's coming SoonTM

@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale Jun 11, 2024
@jbrianceau
Copy link
Member

@zadjii-msft Just for the record, this still doesn't work.

Upgrade from Terminal version 1.21.2361.0 to current version from the Store (1.21.2701.0) on a Windows 11 build higher than 25399 always closes opened Terminal app without warning during the automatic update process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

3 participants