-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when exiting a tab with the debug tap #17432
Comments
Hi I'm an AI powered bot that finds similar issues based off the issue title. Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you! Closed similar issues:
|
This should be fixed by #17450! Could you just double-check that? |
Yes, I can confirm that has fixed it. Thank you! |
I'm reopening because this issue has returned. It was fixed by PR #17450, but that was reverted in PR #17750, and now it's crashing again. Exact same steps to reproduce as above, and the stack trace is similar:
|
Windows Terminal version
Commit c52ba7d
Windows build number
10.0.19045.4412
Other Software
No response
Steps to reproduce
I've had this crash quite frequently in the preview build (I think possibly since v1.21), but I couldn't easily reproduce it. However, I've just discovered I can reproduce it consistently when running Windows Terminal from within the debugger with the following steps:
exit
to close the second tab.In both tabs I'm using a WSL bash shell, but I don't think that's relevant. The key thing is typing
exit
to close the tab rather than clicking on the close button.Expected Behavior
The tab should close without crashing the terminal.
Actual Behavior
The terminal crashes with an exception in the
Pane::_CloseChild
method:On this line:
terminal/src/cascadia/TerminalApp/Pane.cpp
Line 1433 in a7e2b46
And with the following stack trace:
When I've had this crash in the preview build (assuming it was the same thing), it was usually when I was attempting to compile Windows Terminal and my system was low on memory. At the time I thought the lack of memory might have been a factor, but I suspect now that it might be a timing issue, and the low memory was just slowing the system enough for it to trigger the problem. Either way I'm hoping the trace above is enough for someone to figure out the cause.
I had also initially thought this might be the same bug as #17305, but my dev build has both PR #17333 and PR #17358 applied, so it can't be that.
The text was updated successfully, but these errors were encountered: