Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when there are multiple panes, entering pane zoom mode and closing the current pane will cause the program to crash and exit #17869

Closed
lost22git opened this issue Sep 6, 2024 · 1 comment · Fixed by #17886
Closed

when there are multiple panes, entering pane zoom mode and closing the current pane will cause the program to crash and exit #17869

lost22git opened this issue Sep 6, 2024 · 1 comment · Fixed by #17886
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal.

Comments

@lost22git
Copy link

lost22git commented Sep 6, 2024 •
edited
Loading

Windows Terminal version

1.22.240823002-preview

Windows build number

10.0.22631.0

Other Software

No response

Steps to reproduce

2

Expected Behavior

only close currren pane

Actual Behavior

close all panes and quit program
@lost22git lost22git added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 6, 2024
@lost22git
Copy link
Author

Perhaps a more accurate description is: when there are multiple panes, entering pane zoom mode and closing the current pane will cause the program to crash and exit

@lost22git lost22git changed the title CTRL+SHIFT+W close all panes when in pane zoom mode when there are multiple panes, entering pane zoom mode and closing the current pane will cause the program to crash and exit Sep 6, 2024
@j4james j4james mentioned this issue Sep 7, 2024
Closed
@lhecker lhecker added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Product-Terminal The new Windows Terminal. Priority-1 A description (P1) and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 9, 2024
@lhecker lhecker mentioned this issue Sep 9, 2024
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Sep 9, 2024
zadjii-msft pushed a commit that referenced this issue Sep 12, 2024
@lhecker
Fix a crash on pane close (#17886)
bc6f3e2 
The underlying issue is that the "Pane" is used both as a model and as
a UI element and so a pane loses its content as soon as it is closed,
but the tree only gets reordered after the animation has finished.
This PR is truly just a hotfix, because it doesn't solve this issue,
it only adds checks to the function that crashes.

Closes #17869
Closes #17871

## Validation Steps Performed
* `Split pane` a few times
* Run the "Close all other panes" action
* Doesn't crash ✅
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Sep 12, 2024
DHowett pushed a commit that referenced this issue Sep 16, 2024
@lhecker @DHowett
Fix a crash on pane close (#17886)
bdb67a3 
The underlying issue is that the "Pane" is used both as a model and as
a UI element and so a pane loses its content as soon as it is closed,
but the tree only gets reordered after the animation has finished.
This PR is truly just a hotfix, because it doesn't solve this issue,
it only adds checks to the function that crashes.

Closes #17869
Closes #17871

## Validation Steps Performed
* `Split pane` a few times
* Run the "Close all other panes" action
* Doesn't crash ✅

(cherry picked from commit bc6f3e2)
Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgTEJYE
Service-Version: 1.21
DHowett pushed a commit that referenced this issue Sep 16, 2024
@lhecker @DHowett
Fix a crash on pane close (#17886)
d95a77b 
The underlying issue is that the "Pane" is used both as a model and as
a UI element and so a pane loses its content as soon as it is closed,
but the tree only gets reordered after the animation has finished.
This PR is truly just a hotfix, because it doesn't solve this issue,
it only adds checks to the function that crashes.

Closes #17869
Closes #17871

## Validation Steps Performed
* `Split pane` a few times
* Run the "Close all other panes" action
* Doesn't crash ✅

(cherry picked from commit bc6f3e2)
Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgS3Ndk PVTI_lADOAF3p4s4AmhmQzgTEJYM
Service-Version: 1.22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a crash on pane close microsoft/terminal
2 participants
@lhecker @lost22git