Bell does not work or does not exist #2952
Assignees
Labels
Area-VT
Virtual Terminal sequence support
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Priority-2
A description (P2)
Product-Conpty
For console issues specifically related to conpty
Resolution-Fix-Committed
Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Comments
ghost
added
Needs-Triage
zadjii-msft
added
Area-VT
zadjii-msft
added
Needs-Tag-Fix
|
Honestly yea we should be passing through the BEL. |
DHowett-MSFT
removed
the
Needs-Triage
DHowett-MSFT
pushed a commit
that referenced
this issue
Sep 30, 2019
🔔 [insert Chorus of the Bells here -DHowett] Fixes #2952.
ghost
added
Needs-Tag-Fix
DHowett-MSFT
pushed a commit
that referenced
this issue
Oct 3, 2019
🔔 [insert Chorus of the Bells here -DHowett] Fixes #2952.
|
🎉This issue was addressed in #2990, which has now been successfully released as Handy links: |
Thanks |
|
We're not actually emitting a bell right now, but the underlying infrastructure now supports it. |
DHowett-MSFT
pushed a commit
that referenced
this issue
Oct 17, 2019
DHowett-MSFT
pushed a commit
that referenced
this issue
Oct 17, 2019
- Fix snapping to the cursor in "Terminal Scrolling" mode (GH-2705) fixes GH-1222 PSReadline calls SetConsoleCursorPosition on each character. We try to snap. However, we'd only ever do this with the visible viewport, the viewport defined by `SCREEN_INFORMATION::_viewport`. When there's a virtual viewport in Terminal Scrolling mode, we actually need to snap the virtual viewport, so that this behavior looks more regular. (cherry picked from commit 6f4b98a) - Passthrough BEL in conpty (GH-2990) fixes GH-2952. (cherry picked from commit 6831120) - make filling chars (and, thus, erase line/char) unset wrap (GH-2831) EraseInLine calls `FillConsoleOutputCharacterW()`. In filling the row with chars, we were setting the wrap flag. We need to specifically not do this on ANY _FILL_ operation. Now a fill operation UNSETS the wrap flag if we fill to the end of the line. Originally, we had a boolean `setWrap` that would mean... - **true**: if writing to the end of the row, SET the wrap value to true - **false**: if writing to the end of the row, DON'T CHANGE the wrap value ,- current wrap value | ,- fill last cell? | | ,- new wrap value | | | ,- comments |-|-|-| |1|0|0| THIS CASE WAS UNHANDLED To handle that special case (1-0-0), we need to UNSET the wrap. So now, we have ~setWrap~ `wrap` mean the following: - **true**: if writing to the end of the row, SET the wrap value to TRUE - **false**: if writing to the end of the row, SET the wrap value to FALSE - **nullopt**: leave the wrap value as it is Closes GH-1126 (cherry picked from commit 4dd9f9c) - When reverse indexing, preserve RGB/256 attributes (GH-2987) (cherry picked from commit 847d6b5) - do not allow CUU and CUD to move "across" margins. (GH-2996) If we're moving the cursor up, its vertical movement should be stopped at the top margin. Similarly, this applies to moving down and the bottom margin. Fixes GH-2929. (cherry picked from commit 0ce08af) - Prevent the v1 propsheet from zeroing colors, causing black text on black background. (GH-2651) fixes GH-2319 (cherry picked from commit b97db63) - Render the cursor state to VT (GH-2829) (cherry picked from commit a9f3849) - Don't put NUL in the buffer in VT mode (GH-3015) (cherry picked from commit a82d6b8) - Return to ground when we flush the last char (GH-2823) The InputStateMachineEngine was incorrectly not returning to the ground state after flushing the last sequence. That means that something like alt+backspace would leave us in the Escape state, not the ground state. This makes sure we return to ground. Additionally removes the "Parser.UnitTests-common.vcxproj" file, which was originally used for a theoretical time when we only open-sourced the parser. It's unnecessary now, and we can get rid of it. Also includes a small patch to bcz.cmd, to make sure bx works with projects with a space in their name. (cherry picked from commit 53c81a0) - Add support for passing through extended text attributes, like… (GH-2917) ... Related work items: #23678919, #23678920, #23731910, #23731911, #23731912, #23731913, #23731914, #23731915, #23731916, #23731917, #23731918
|
In WT 0.6... I continue to not hear any bell... does it mean we have to customize something in profiles? In MSYS2 profile I DO hear |
|
Sorry: this workitem was repurposed to track getting bell working through the intermediate layers of the console subsystem behind Windows Terminal, so that all terminals on windows could start belling. We haven't yet implemented bell support in WT itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Many terminals have
bell(beep), a sound which is activated when the user uses completion or make a mistake typing a command. WT does not seem to have it or I have not understood how to set it. I have tries wit Ubuntu, CMD, PS and my setting of MSYS2. Notice the bell/beep works using MinTTY...The text was updated successfully, but these errors were encountered: