Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSCode's integrated terminal can not support bold character while enabling ConPTY. #3297

Closed
Suyun514 opened this issue Oct 23, 2019 · 2 comments
Closed

VSCode's integrated terminal can not support bold character while enabling ConPTY. #3297

Suyun514 opened this issue Oct 23, 2019 · 2 comments
Labels
Needs-Tag-Fix Doesn't match tag requirements Resolution-External For issues that are outside this codebase

Comments

@Suyun514
Copy link

Suyun514 commented Oct 23, 2019 •
edited
Loading

Environment

Windows build number: Microsoft Windows [Version 10.0.18362.418]
Windows Terminal version (if applicable):

Any other software? Viaual Studio Code 1.40.0-insider

Steps to reproduce

  1. Set "terminal.integrated.windowsEnableConpty": true.
  2. Install Cygwin.
  3. Set the default shell as bash.exe(for Cygwin) in Viaual Studio Code, and the args as --login.
  4. Run ls --color=auto.

Expected behavior

The executable files and the folders' names are displayed in bold. (You can check the bold character in MinTTY with the option Show bold ad font.)

Actual behavior

There is nothing displayed in bold.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 23, 2019
@Suyun514 Suyun514 mentioned this issue Oct 23, 2019
Closed
@Tyriar
Copy link
Member

Tyriar commented Oct 23, 2019 •
edited
Loading

You should try repro with Windows Terminal and give the version

@DHowett-MSFT
Copy link
Contributor

image

This is in VS Code. I'm 99% sure this is a Cygwin issue, because they have their own VT parser, and they probably don't think we can handle VT.

More in #2837 (comment).

@DHowett-MSFT DHowett-MSFT added Resolution-External For issues that are outside this codebase and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs-Tag-Fix Doesn't match tag requirements Resolution-External For issues that are outside this codebase
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Tyriar @DHowett-MSFT @Suyun514