Clicking the current tab to raise the window should focus the text area #3609

FaffeF · 2019-11-17T18:33:11Z

Environment

Windows build number: 10.0.18363.0
Windows Terminal version: 0.6.2951.0

Any other software? Nope

Steps to reproduce

Start Terminal
Focus another window
Re-focus Terminal by clicking on the active tab
Enter text using your keyboard

Expected behavior

Raising the Terminal window should focus the text area no matter how you do it.

Works as expected if you click any other tab than the currently active.

Actual behavior

Text input is ignored even though the Terminal window has focus. Text input is restored when clicking the text area or focusing another tab.

The text was updated successfully, but these errors were encountered:

egmontkob · 2019-11-17T21:55:23Z

gnome-terminal used to suffer from this problem, too. It was super annoying.

zadjii-msft · 2019-11-18T14:05:54Z

Thanks for the report! This is actually something that's already being tracked in #1205 / #552, and is fortunately in PR in #3540. Hopefully should be fixed in the next release.

/dup #1205
/dup #552

ghost · 2019-11-18T14:05:57Z

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

FaffeF · 2019-11-18T19:20:58Z

Well, my searching skills are apparently not up to the task ¯_(ツ)_/¯

And that should probably be /dup #522, not 552

FaffeF · 2019-11-26T19:58:28Z

This is not fixed in 0.7.3291.0

zadjii-msft · 2019-11-26T20:10:06Z

AH what happened?! This definitely was fixed in a previous commit of mine. Must have somehow regressed during the PR. I'll re-open and re-investigate.

DJackman123 · 2020-01-07T23:26:29Z

Confirming that it doesn't work for me, either. I'm on version 0.8.3651.0 of Terminal. I played around with this a bit and found that it works fine when I use Alt-Tab to make Terminal the active window. It also works when I click on the tab bar (but not a tab) of Terminal, or when I click on an inactive tab, or even the drop-down menu. It also works when using Ctrl-Tab or clicking inactive tabs when Terminal is active.
However, if I click on the active tab then focus is removed from the text area of the window. This happens regardless of whether Terminal is the active window when clicking the tab.

FaffeF · 2020-03-20T17:50:27Z

A bit sad this is still not fixed in 0.10.781.0 😥

FaffeF · 2020-08-14T17:56:56Z

Really hard to fix, or just keeps getting left on the backlog?

DHowett · 2020-08-14T18:01:47Z

@FaffeF #6290 (comment)

zadjii-msft · 2020-08-14T18:03:24Z

Honestly a bit of both. Hard to come up with a good, comprehensive way to prevent this from regressing in the future, and also not be hard to maintain, and because of that, it just keeps getting left behind.

IIRC one of the solutions I imagined required that every UI element we add to manually do some work to do the right thing, and that's not great. Like having the cmdpal toss the focus back to the focused control isn't wrong, but it doesn't handle the search/find box appropriately. So we could do a similar thing with the tabs, presuming we fix the search box focus issue. But then also the tab color picker needs to manually toss the focus back, and the tab context menu, and the tab renamer, and anything else we might add, so that doesn't seem the most scalable

mle-ii · 2020-08-14T18:51:18Z

Luckily this is not too hard to work around. I tried a few things out, so besides clicking in the terminal window area one can hit tab 2 times or click a different tab and back to the tab you want. But yeah, I've sent a few words off into the ether after clicking a tab. LOL

I suppose some other possibilities until this can get fixed without breaking things is to show that the tab UI has focus (you can see focus shown if you hit left or right arrow key when the tab has focus) and/or flash when the tab UI has focus and you type. Or perhaps when certain keys, like say alpha/numeric are hit the focus moves to the terminal and text gets sent there.

What is odd is that Ctrl+Tab cycling around through the tabs or back again with Ctrl+Shift+Tab gives the window the proper focus when is back to that tab.

And I agree, getting focus right is very hard. I spent several years of my working career at MS in my past working on testing UI controls. :)

A redo of #6290. That PR was overkill. In that one, we'd toss focus back to the active control any time that the tab view item got focus. That's maybe not the _best_ solution. Instead, this PR is precision strikes. We're re-using a lot of what we already have from #9260. * When the context menu is closed, yeet focus to the control. * When the renamer is dismissed, yeet focus to the control. * When the TabViewItem is tapped (meaning no one else handled it), yeet focus to the control. ### checklist * [x] I work here * [ ] This is UI so it doesn't have tests * [x] Closes #3609 * [x] Closes #5750 * [x] Closes #6680 ### scenarios: * [x] focus the window by clicking on the tab -> Control is focused. * [x] Open the color picker with the context menu, can move the focus inside the picker with the arrow keys. * [x] Dismiss the picker with esc -> Control is focused. * [x] Dismiss the picker with enter -> Control is focused. * [x] Dismiss the renamer with esc -> Control is focused. * [x] Dismiss the renamer with enter -> Control is focused. * [x] Dismiss the context menu with esc -> Control is focused. * [x] Start renaming, then click on the tab -> Rename is committed, Control is focused. * [x] Start renaming, then click on the text box -> focus is still in the text box

A redo of #6290. That PR was overkill. In that one, we'd toss focus back to the active control any time that the tab view item got focus. That's maybe not the _best_ solution. Instead, this PR is precision strikes. We're re-using a lot of what we already have from #9260. * When the context menu is closed, yeet focus to the control. * When the renamer is dismissed, yeet focus to the control. * When the TabViewItem is tapped (meaning no one else handled it), yeet focus to the control. * [x] I work here * [ ] This is UI so it doesn't have tests * [x] Closes #3609 * [x] Closes #5750 * [x] Closes #6680 * [x] focus the window by clicking on the tab -> Control is focused. * [x] Open the color picker with the context menu, can move the focus inside the picker with the arrow keys. * [x] Dismiss the picker with esc -> Control is focused. * [x] Dismiss the picker with enter -> Control is focused. * [x] Dismiss the renamer with esc -> Control is focused. * [x] Dismiss the renamer with enter -> Control is focused. * [x] Dismiss the context menu with esc -> Control is focused. * [x] Start renaming, then click on the tab -> Rename is committed, Control is focused. * [x] Start renaming, then click on the text box -> focus is still in the text box (cherry picked from commit 8564b26)

ghost · 2021-05-25T19:05:30Z

🎉This issue was addressed in #10048, which has now been successfully released as Windows Terminal v1.8.1444.0.:tada:

Handy links:

ghost · 2021-05-25T19:08:45Z

🎉This issue was addressed in #10048, which has now been successfully released as Windows Terminal Preview v1.9.1445.0.:tada:

Handy links:

FaffeF · 2021-05-25T22:23:30Z

Halleluja!

ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 17, 2019

ghost closed this as completed Nov 18, 2019

ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 18, 2019

zadjii-msft reopened this Nov 26, 2019

zadjii-msft added this to the Terminal-1912 milestone Nov 26, 2019

zadjii-msft self-assigned this Dec 4, 2019

nickcano mentioned this issue Jan 5, 2020

Active terminal does not get focus when window gets focus #522

Closed

zadjii-msft modified the milestones: Terminal-1912, Terminal-2001 Jan 6, 2020

DHowett-MSFT mentioned this issue Jan 9, 2020

Issues pasting into the new terminal. #4118

Closed

cinnamon-msft modified the milestones: Terminal v0.9, Terminal v0.10 Jan 16, 2020

cinnamon-msft modified the milestones: Terminal v0.10, Terminal v1.x Jan 28, 2020

This comment has been minimized.

Sign in to view

cinnamon-msft modified the milestones: Terminal v1.3, Terminal v1.4 Aug 27, 2020

This comment has been minimized.

Sign in to view

cinnamon-msft modified the milestones: Terminal v1.4, Terminal v1.5 Sep 24, 2020

This comment has been minimized.

Sign in to view

zadjii-msft modified the milestones: Terminal v1.5, Terminal v2.0 Nov 4, 2020

zadjii-msft mentioned this issue Nov 19, 2020

Cursor and focus leaves current window after clicking on tab #8323

Closed

KalleOlaviNiemitalo mentioned this issue Dec 26, 2020

Click on tab ... focus ...? #8662

Closed

j4james mentioned this issue Jan 19, 2021

Clicking the active tab removes focus from active shell session #8822

Closed

zadjii-msft mentioned this issue Feb 11, 2021

Hitting ALT-F4 in the settings UI doesn't close WT #9042

Closed

j4james mentioned this issue Apr 5, 2021

Activating terminal by clicking on the tab does not set input focus #9707

Closed

zadjii-msft mentioned this issue Apr 19, 2021

Clicking a tab triggers focus lose #9886

Closed

zadjii-msft mentioned this issue May 6, 2021

In specific scenarios, focus the active control #10048

Merged

14 tasks

ghost closed this as completed in #10048 May 11, 2021

ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels May 11, 2021

This issue was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clicking the current tab to raise the window should focus the text area #3609

Clicking the current tab to raise the window should focus the text area #3609

FaffeF commented Nov 17, 2019

egmontkob commented Nov 17, 2019

zadjii-msft commented Nov 18, 2019

ghost commented Nov 18, 2019

FaffeF commented Nov 18, 2019

FaffeF commented Nov 26, 2019

zadjii-msft commented Nov 26, 2019

DJackman123 commented Jan 7, 2020

FaffeF commented Mar 20, 2020

This comment has been minimized.

FaffeF commented Aug 14, 2020

DHowett commented Aug 14, 2020

zadjii-msft commented Aug 14, 2020

mle-ii commented Aug 14, 2020

This comment has been minimized.

This comment has been minimized.

ghost commented May 25, 2021

ghost commented May 25, 2021

FaffeF commented May 25, 2021

Clicking the current tab to raise the window should focus the text area #3609

Clicking the current tab to raise the window should focus the text area #3609

Comments

FaffeF commented Nov 17, 2019

Environment

Steps to reproduce

Expected behavior

Actual behavior

egmontkob commented Nov 17, 2019

zadjii-msft commented Nov 18, 2019

ghost commented Nov 18, 2019

FaffeF commented Nov 18, 2019

FaffeF commented Nov 26, 2019

zadjii-msft commented Nov 26, 2019

DJackman123 commented Jan 7, 2020

FaffeF commented Mar 20, 2020

This comment has been minimized.

FaffeF commented Aug 14, 2020

DHowett commented Aug 14, 2020

zadjii-msft commented Aug 14, 2020

mle-ii commented Aug 14, 2020

This comment has been minimized.

This comment has been minimized.

ghost commented May 25, 2021

ghost commented May 25, 2021

FaffeF commented May 25, 2021