Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

White border when Terminal is dark while Windows is in Light theme #4980

Closed
hylowaker opened this issue Mar 18, 2020 · 3 comments · Fixed by #5105
Closed

White border when Terminal is dark while Windows is in Light theme #4980

hylowaker opened this issue Mar 18, 2020 · 3 comments · Fixed by #5105
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal Backlog

Comments

@hylowaker
Copy link

Environment

Windows build number: Microsoft Windows [Version 10.0.19582.1001]
Windows Terminal version (if applicable): 0.10.761.0

Steps to reproduce

  1. Set Windows theme to Light.
  2. In profiles.json, set "requestedTheme": "dark" and "showTabsInTitlebar": true
  3. Focus on the window.

Expected behavior

No white borders, regardless of Windows theme color. (Like as VSCode)

Actual behavior

image

Though #4817 fixes the white border issue for Dark mode in Windows, the border still presents with the combination of dark theme for Terminal settings and light theme for Windows.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 18, 2020
@be5invis be5invis mentioned this issue Mar 18, 2020
Closed
@DHowett-MSFT DHowett-MSFT added this to the Terminal Backlog milestone Mar 19, 2020
@DHowett-MSFT
Copy link
Contributor

So, we're doing our level best with the system API here. I'm going to keep this one around tracking our switch to the final API when it's out.

@DHowett-MSFT DHowett-MSFT added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 19, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 19, 2020
@DHowett-MSFT DHowett-MSFT mentioned this issue Mar 19, 2020
Closed
29 tasks
DHowett-MSFT pushed a commit that referenced this issue Mar 24, 2020
@DHowett
Make the window border actually follow the user's theme
d2067a7 
One of our great contributors already hooked up all the logic for this,
we just needed a theme library that could handle the request.

Fixes #4980.
@DHowett-MSFT DHowett-MSFT mentioned this issue Mar 24, 2020
Merged
4 tasks
@ghost ghost added the In-PR This issue has a related PR label Mar 24, 2020
@ghost ghost closed this as completed in #5105 Mar 24, 2020
ghost pushed a commit that referenced this issue Mar 24, 2020
@DHowett
Make the window border actually follow the user's theme (#5105)
176badf 
## Summary of the Pull Request

One of our great contributors already hooked up all the logic for this,
we just needed a theme library that could handle the request.

## PR Checklist
* [x] Fixes #4980
* [x] CLA signed
* [x] Tests added/passed
* [ ] Requires documentation to be updated
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Mar 24, 2020
@ghost
Copy link

ghost commented Apr 22, 2020

🎉This issue was addressed in #5105, which has now been successfully released as Windows Terminal Preview v0.11.1121.0.:tada:

Handy links:

@michalhudecek
Copy link

This has not been fixed. There should be no white border regardless the theme as mentioned in Expected behavior in this issue

image

@michalhudecek michalhudecek mentioned this issue Jun 21, 2020
Closed
@MatthewCroughan MatthewCroughan mentioned this issue Jul 5, 2020
Closed
@loopervfx loopervfx mentioned this issue Feb 25, 2021
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal Backlog
Development

Successfully merging a pull request may close this issue.

Make the window border actually follow the user's theme microsoft/terminal
3 participants
@michalhudecek @hylowaker @DHowett-MSFT