Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comments and settings to settings.json for discoverability #5188

Closed
cinnamon-msft opened this issue Mar 30, 2020 · 1 comment · Fixed by #5217
Closed

Add comments and settings to settings.json for discoverability #5188

cinnamon-msft opened this issue Mar 30, 2020 · 1 comment · Fixed by #5217
Assignees
@carlos-zamora
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@cinnamon-msft
Copy link
Contributor

Description of the new feature/enhancement

We should add comments above each major section with the link to our documentation.

Additionally, we should add the following settings to settings.json so people can find them easily:

Settings

  • "copyOnSelect": false

Key bindings

  • { "command": "find", "keys": "ctrl+shift+f" }
    This would also be bound in defaults.json, but we can explain "unbound"/null in a comment above it.
  • { "command": {"action": "splitPane", "split": "auto", "splitMode": "duplicate"}, "keys": "alt+shift+d" }
    This is a common panes use case and it also demonstrates the fact that we have panes and shows how the key bindings are formatted.

Proposed technical implementation details (optional)
@cinnamon-msft cinnamon-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Mar 30, 2020
@cinnamon-msft cinnamon-msft added this to the Terminal v1.0 milestone Mar 30, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 30, 2020
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 30, 2020
@carlos-zamora carlos-zamora self-assigned this Apr 1, 2020
@carlos-zamora carlos-zamora mentioned this issue Apr 2, 2020
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Apr 2, 2020
@ghost ghost closed this as completed in #5217 Apr 9, 2020
ghost pushed a commit that referenced this issue Apr 9, 2020
@carlos-zamora
Update default settings.json experience (#5217)
c65de31 
## Summary of the Pull Request
Add comments and settings to settings.json for discoverability.

## PR Checklist
* [X] Closes #5187 
* [X] Closes #5188 
* [X] Closes #3058
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Apr 9, 2020
@ghost
Copy link

ghost commented Apr 22, 2020

🎉This issue was addressed in #5217, which has now been successfully released as Windows Terminal Preview v0.11.1121.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Update default settings.json experience microsoft/terminal
3 participants
@carlos-zamora @DHowett-MSFT @cinnamon-msft