Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking in a non-terminal control area should not steal focus from the terminal control #528

Closed
oising opened this issue May 7, 2019 · 10 comments
Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Available It's available in an Insiders build or a release
Milestone

Comments

@oising
Copy link
Collaborator

oising commented May 7, 2019

  • Your Windows build number: (Type ver at a Windows Command Prompt)

18.0.18362.53

  • What you're doing and what's happening: (Copy & paste specific commands and their output, or include screen shots)
  1. start terminal
  2. hit ctrl+t to bring up tabs
  3. click in the space between second tab and "+" and attempt to drag window
  4. window won't drag, but now input is blocked
  5. right click in window area
  6. input is now unblocked.

This is unlikely to occur when the tabs are NOT inlined with the title bar. It is very likely to happen when tabs ARE inlined, as the free space seems like empty title bar area.

  • What's wrong / what should be happening instead:

Either allow window dragging from tabs bar (when inlined), or don't allow window dragging but don't lock up input. Maybe a prompt or tooltip text might help guide the user if dragging is disabled from this area.

@zadjii-msft
Copy link
Member

Well that certainly shouldn't be happening.

The part of the tab bar without tabs definitely shouldn't steal focus, so that's certainly a bug.

When the tabs are in the titlebar, that area should be able to drag the window around, but unfortunately there's an existing bug with XAML Islands that prevents that from working.

I'll use this issue to primarily track the first problem, as the second is an external issue.

@zadjii-msft zadjii-msft added the Issue-Bug It either shouldn't be doing this or needs an investigation. label May 7, 2019
@zadjii-msft zadjii-msft added this to the Windows Terminal v1.0 milestone May 7, 2019
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@miniksa miniksa added Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. and removed Mass-Chaos labels May 17, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@miniksa miniksa added Needs-Tag-Fix Doesn't match tag requirements and removed Area-User Interface Issues pertaining to the user interface of the Console or Terminal labels May 17, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@rbeesley
Copy link
Contributor

I don't know if this should be a new bug, but it is certainly related to this. I went spelunking for this specific bug, so I'll leave a comment here and then file a new one. When you open Terminal on a screen with standard DPI, the gap between the drop down and the minimize is small, so your dragable surface is small. When you move Terminal to a monitor with an HDPI / 150% scale, that gap goes away entirely and you have to use the small gap between the client area and the minimize button... since you can't use the empty space to drag the terminal. Resolving #528 will mostly solve the problem I'm filing, but I think there is an issue with how the controls are rendered on different scaled monitors.

@Jaykul
Copy link
Contributor

Jaykul commented Jun 22, 2019

Side note: on some of those other Windows Apps ... (like Edge) they make the new tab buttons stick right to the right side of the visible tab, so anything to the right of that is dragable. ❤

Also, they make all the tabs the same width so you don't get the whole window taken up when all you have is a couple of PowerShell instances ... but they show up as "C:\Windows\System32\WindowsPowerShell\v1.0\PowerShell.exe" 🤨

@Talvish
Copy link

Talvish commented Jun 22, 2019

@Jaykul I'm with you on the making the '+' bind to the right of the tabs (need more drag space). Same width is a bit tougher since you have an option to set the title to be the directory you are in, so can see this as optional.

Update: Just read #56 which refers to #929 ... looks like the draggable space is being addressed.

@cinnamon-msft cinnamon-msft added the Severity-DataLoss A bug that causes the user's data to be lost, unintentionally label Jun 25, 2019
@Poopooracoocoo
Copy link

In addition to tooltips, the active tab could be full width. I'm not sure about hover.

@Jaykul @Talvish

@Jaykul
Copy link
Contributor

Jaykul commented Jun 29, 2019

@Talvish not sure why it matters how wide the text is. It doesn't seem to matter to my browsers...

@rbeesley
Copy link
Contributor

rbeesley commented Jun 29, 2019

@Jaykul looking at my browser right now, if I had as many tabs open in Terminal, every one would say "C:\Wind," and that's about it. To fix this, we really need big-endian directory structures: "System32\Windows\C:" (or is that little?), or maybe we need to start reading RTL. I think this ship may have sailed. Maybe justify the directory name on the working directory, so you'd see something like C:\Windows\[Syste]m32, where the part in the square brackets is the part which is windowed on the tab when it gets small.

@zadjii-msft zadjii-msft changed the title Attempting to drag window using empty space with inline tabs row locks terminal Clicking in a non-terminal control area should not steal focus from the terminal control Jul 1, 2019
@zadjii-msft zadjii-msft removed this from the Terminal v0.3 - Preview 2 milestone Jul 25, 2019
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Jul 25, 2019
@zadjii-msft zadjii-msft removed the Severity-DataLoss A bug that causes the user's data to be lost, unintentionally label Jul 25, 2019
@DHowett-MSFT
Copy link
Contributor

I think we've gotten rid of a bunch of ways this might have happened, so I'm gonna close this out for now. Thanks for playing!

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Feb 28, 2020
@DHowett-MSFT DHowett-MSFT added the Resolution-Fix-Available It's available in an Insiders build or a release label Feb 28, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Feb 28, 2020
@virgoparna
Copy link

Version: 1.12.10982.0
Clicking on empty space on tab bar activates window, but does not activate current terminal (keyboard input does not go to terminal).

@zadjii-msft
Copy link
Member

@virgoparna This particular version of this bug has been fixed for a couple years now - if you're still seeing this on a new version, then I'm guessing that it's a new variation on this bug and should get a new issue opened to track it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Available It's available in an Insiders build or a release
Projects
None yet
Development

No branches or pull requests

10 participants