Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultProfile setting doesn't work #5527

Closed
BesedinSasha opened this issue Apr 24, 2020 · 6 comments
Closed

defaultProfile setting doesn't work #5527

BesedinSasha opened this issue Apr 24, 2020 · 6 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@BesedinSasha
Copy link

After update to version 0.11.1121.0 setting defaultProfile doesn't work and always open PowerShell terminal by default.

Environment

Windows 10 Home Build 19592

Steps to reproduce

Edit settings.json to use Ubuntu terminal
image
image

Actual behavior

After change defaultProfile to Ubuntu terminal or even cmd by default uses PowerShell.

image

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 24, 2020
@Sukiyakijango
Copy link

same here

@mdtauk
Copy link

mdtauk commented Apr 24, 2020

The Settings format has been changed, and there is no longer a specific "globals" section.

@BesedinSasha
Copy link
Author

@mdtauk thanks a lot! I moved settings from globals section to root and it works as expected.

@wukann
Copy link

wukann commented Apr 24, 2020

Oh, I read that in CHANGELOG... (´・ω・`)

https:/microsoft/terminal/releases/tag/v0.11.1121.0

BREAKING CHANGE We've deleted a lot of legacy settings handling (#5190)
Please see our blog post and our most recent status update for more information.
If you had settings hanging out in the globals dictionary, you'll want to move them out.
Failure to do so will cause us to ignore your default profile, launch mode, etc., etc.

@zadjii-msft
Copy link
Member

Thanks for the report! 0.11 introduced some breaking settings changes which is probably causing this issue for you. This is tracked by another issue on our repo - please refer to #5458 for more discussion.

/dup #5458

@ghost
Copy link

ghost commented Apr 24, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Apr 24, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 24, 2020
ghost pushed a commit that referenced this issue Apr 27, 2020
This property was deprecated in 0.11. We probably should have also added a warning
message to help the community figure out that this property is gone and won't work
anymore.

This PR adds that warning.

* I'm not going to list the enormous number of duped threads _wait yes I am_
    * #5581
    * #5547
    * #5555
    * #5557
    * #5573 
    * #5532
    * #5527
    * #5535 
    * #5510
    * #5511
    * #5512
    * #5513
    * #5516
    * #5515
    * #5521 
    * This literally isn't even all of them 

* [x] Also mainly related to #5458
* [x] I work here
* [x] Tests added/passed
DHowett-MSFT pushed a commit that referenced this issue Apr 27, 2020
This property was deprecated in 0.11. We probably should have also added a warning
message to help the community figure out that this property is gone and won't work
anymore.

This PR adds that warning.

* I'm not going to list the enormous number of duped threads _wait yes I am_
    * #5581
    * #5547
    * #5555
    * #5557
    * #5573
    * #5532
    * #5527
    * #5535
    * #5510
    * #5511
    * #5512
    * #5513
    * #5516
    * #5515
    * #5521
    * This literally isn't even all of them

* [x] Also mainly related to #5458
* [x] I work here
* [x] Tests added/passed

(cherry picked from commit d6cae40)
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

5 participants