Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toggleRetroEffect to schema #6762

Closed
carlos-zamora opened this issue Jul 2, 2020 · 1 comment · Fixed by #6806
Closed

Add toggleRetroEffect to schema #6762

carlos-zamora opened this issue Jul 2, 2020 · 1 comment · Fixed by #6806
Assignees
@zadjii-msft
Labels
Area-Schema Things that have to do with the json schema. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.2

Comments

@carlos-zamora
Copy link
Member

#6691 got merged without updating schema/docs. Whoops!
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-Schema Things that have to do with the json schema. labels Jul 2, 2020
@carlos-zamora carlos-zamora added this to the Terminal v1.2 milestone Jul 2, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 2, 2020
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 2, 2020
@DHowett
Copy link
Member

DHowett commented Jul 2, 2020

Shouldn'a signed off eh

@zadjii-msft zadjii-msft mentioned this issue Jul 6, 2020
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Jul 6, 2020
@zadjii-msft zadjii-msft mentioned this issue Jul 7, 2020
Merged
4 tasks
@ghost ghost closed this as completed in #6806 Jul 7, 2020
ghost pushed a commit that referenced this issue Jul 7, 2020
@zadjii-msft
Add actions missing in schema, descriptions for toggleRetroEffect (#…
5bc31a1 
…6806)

## Summary of the Pull Request

In the wake of #6635, a couple things got missed in merges:
* `toggleRetroEffect` didn't get into the schema, nor did `renameTab` or
  `commandPalette`.
* `toggleRetroEffect` also didn't get a name

Furthermore, I thought it might be a good idea to start sticking
commands into `bindings` even without `keys`. So I tried doing that for
`opentabColorPicker` and `toggleRetroEffect`, and found immediately that
the labels for the key chord still appear even when the text is empty.
So I added some XAML magic to hide those when the text is empty.

## References
* #6762 
* #6691
* #6557 
* #6635 

## PR Checklist
* [x] Closes #6762
* [x] I work here
* [x] Tests added/passed
* [n/a] Requires documentation to be updated

## Detailed Description of the Pull Request / Additional comments

* See also: https://docs.microsoft.com/en-us/windows/uwp/data-binding/data-binding-quickstart#formatting-or-converting-data-values-for-display
  - make sure to switch to C++/WinRT at the top!

## Validation Steps Performed
Removed all my manual actions, ran the Terminal:
![image](https://user-images.githubusercontent.com/18356694/86652356-f5a79400-bfa9-11ea-9131-5b7d3e835e19.png)
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 7, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-Schema Things that have to do with the json schema. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.2
Development

Successfully merging a pull request may close this issue.

Add actions missing in schema, descriptions for toggleRetroEffect microsoft/terminal
3 participants
@DHowett @carlos-zamora @zadjii-msft