Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setcolorscheme command producing an error #7432

Closed
cis-admin opened this issue Aug 27, 2020 · 8 comments
Closed

setcolorscheme command producing an error #7432

cis-admin opened this issue Aug 27, 2020 · 8 comments
Labels
Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Resolution-Answered Related to questions that have been answered

Comments

@cis-admin
Copy link

Running the latest Windows Terminal Preview, Version: 1.3.2382.0, and I'm seeing the following error when trying to invoke the setcolorscheme command:

Warnings were found while parsing your keybindings:
• Found a keybinding that was missing a required parameter value. This keybinding will be ignored.

Here is the command I am using in my settings.json:

{ "command": { "action": "setColorScheme", "name": "One Half Dark" }, "keys": "ctrl+shift+i" },

The color scheme, One Half Dark, is present in my schemes. Any idea why I may be seeing that error?

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 27, 2020
@zadjii-msft
Copy link
Member

zadjii-msft commented Aug 27, 2020

The parameter is "scheme", not "name" ☺️

https://docs.microsoft.com/en-us/windows/terminal/customize-settings/key-bindings#set-the-color-scheme-preview

EDIT: The parameter is "colorScheme"

@zadjii-msft zadjii-msft added Issue-Question For questions or discussion Resolution-Answered Related to questions that have been answered labels Aug 27, 2020
@DHowett
Copy link
Member

DHowett commented Aug 27, 2020

Closing answered. Thanks!

@DHowett DHowett closed this as completed Aug 27, 2020
@DHowett DHowett closed this as completed Aug 27, 2020
@DHowett DHowett removed Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 27, 2020
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Aug 27, 2020
@cis-admin
Copy link
Author

Thanks for letting me know! It looks like the release notes need to be updated since it says "name" and not "scheme":

https://devblogs.microsoft.com/commandline/windows-terminal-preview-1-3-release/

@zadjii-msft
Copy link
Member

@cinnamon-msft Hey could you go fix the blog post?

@cis-admin
Copy link
Author

So it looks like I still get the same error when inputting:

{ "command": { "action": "setColorScheme", "scheme": "One Half Dark" }, "keys": "ctrl+shift+i" }

@cinnamon-msft
Copy link
Contributor

#6993

Should the schema require "colorScheme" rather than "name"?

@cis-admin
Copy link
Author

#6993

Should the schema require "colorScheme" rather than "name"?

That worked!

@zadjii-msft
Copy link
Member

Yea, I derped and posted the wrong thing after literally opening the docs to the right page 😅 my bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Resolution-Answered Related to questions that have been answered
Projects
None yet
Development

No branches or pull requests

4 participants