Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft.UI.Xaml causes an exception when any flyout menus are generated #760

Closed
finesse-fingers opened this issue May 14, 2019 · 4 comments · Fixed by #3027
Closed

Microsoft.UI.Xaml causes an exception when any flyout menus are generated #760

finesse-fingers opened this issue May 14, 2019 · 4 comments · Fixed by #3027
Assignees
@DHowett-MSFT
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@finesse-fingers
Copy link
Contributor

finesse-fingers commented May 14, 2019 •
edited
Loading

After modifying Cascadia project to debug in "Native Only" mode, I come across this exception, when clicking dropdown menu (to open a new tab in the terminal):

image

File: src/cascadia/WindowsTerminal/main.cpp
Win Version: 10.0.18362.86
VS19: 16.0.3

I would like to investigate if anyone can point me in the right direction.
@DHowett-MSFT
Copy link
Contributor

This seems to only happen when Microsoft.UI.Xaml is loaded into the process. I'd like to hold on to it to make sure that it's not some weird prerelease bug we're hitting.

I'll assign it to myself, to do two things:

  1. Make sure we always have symbols for MUX.dll
  2. Drive the discussion with them on why this might be happening.

@DHowett-MSFT DHowett-MSFT added the Issue-Bug It either shouldn't be doing this or needs an investigation. label May 14, 2019
@DHowett-MSFT DHowett-MSFT self-assigned this May 14, 2019
@DHowett-MSFT DHowett-MSFT added this to the Windows Terminal v1.0 milestone May 14, 2019
@DHowett-MSFT DHowett-MSFT changed the title Debugging in Native Only mode throws hresult_error Microsoft.UI.Xaml causes an exception when any flyout menus are generated May 14, 2019
@drekryan
Copy link

I hit an abort() similar to this in debug with outdated profiles.json after the starting directory changes were made and rendered my previous settings invalid crashing the app or causing an abort(). Dont know if this is related but thought it might give some direction into investigating it.

I deleted my profiles.json file from %LOCALAPPDATA%\packages\Microsoft.WindowsDevTerminal_8wekyb3d8bbwe\RoamingState and allowed it to be regenerated and my build stopped hitting the abort() without a rebuild needed.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@DHowett-MSFT DHowett-MSFT added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels May 17, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@fghzxm
Copy link
Contributor

fghzxm commented May 21, 2019

The interesting part is that I only get this exception thrown when I'm debugging Terminal, not when running it from Start.

@carlos-zamora carlos-zamora mentioned this issue Jun 25, 2019
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue Oct 2, 2019
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Oct 2, 2019
DHowett-MSFT pushed a commit that referenced this issue Oct 15, 2019
@DHowett
Upgrade to Microsoft.UI.Xaml 2.2 (#3027)
df26c67 
* We had to move to the final API:
   * Items -> TabItems
   * Items.VectorChanged -> TabItemsChanged
   * TabClose -> TabCloseRequested
   * TabViewItem.Icon -> TabViewItem.IconSource
* TabRowControl has been converted to a ContentPresenter, which
  simplifies its logic a little bit.
* TerminalPage now differentiates MUX and WUX a little better
* Because of the change from Icon to IconSource in TabViewItem,
  Utils::GetColoredIcon needed to be augmented to support MUX IconSources.
  It was still necessary to use for WUX, so it's been templatized.
* I moved us from WUX SplitButton to MUX SplitButton and brought the
  style in line with the one typically provided by TabView.
* Some of our local controls have had their backgrounds removed so
  they're more amenable to being placed on other surfaces.
* I'm suppressing the TabView's padding.
* I removed a number of apparently dead methods from App.
* I've simplified the dragbar's sizing logic and eventing.
* The winmd harvester needed to be taught to not try to copy winmds for
  framework packages.
* We now only initialize the terminal once we know the size

Closes #1896.
Closes #444.
Closes #857.
Closes #771.
Closes #760.
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 15, 2019
@ghost
Copy link

ghost commented Oct 23, 2019

🎉This issue was addressed in #3027, which has now been successfully released as Windows Terminal Preview v0.6.2951.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett-MSFT DHowett-MSFT

Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Upgrade to Microsoft.UI.Xaml 2.2 microsoft/terminal
5 participants
@drekryan @DHowett-MSFT @miniksa @finesse-fingers @fghzxm