Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move hard-coded strings and UI text to Resources #792

Closed
timheuer opened this issue May 14, 2019 · 4 comments · Fixed by #1972
Closed

Move hard-coded strings and UI text to Resources #792

timheuer opened this issue May 14, 2019 · 4 comments · Fixed by #1972
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@timheuer
Copy link
Member

There are a few places in current iteration that are hard-coding UI-shown values and should move those to resources for easier updating and localization.

Need to determine if following UWP-style resources or RC based.
@DHowett-MSFT
Copy link
Contributor

Thanks for filing this, it's actually the reason we haven't bitten off some of the more interesting things. I think we should be able to use UWP-style resources, but that'll require a good bit of integration work.

The build tools don't seem capable of rolling up multiple levels of component resources into the toplevel app package .pri file. ☹️

@timheuer
Copy link
Member Author

There is a merge capability for PRI (or used to be) that existed for this reason (a component with it's own PRI + app with it's own PRI == single package PRI). It's possible. Good thing is I don't think that you have many strings that will be a part of the host here that are problematic. But you may want resources for other reasons of course too (defaults, etc.)

@DHowett-MSFT
Copy link
Contributor

It's possible, but the "Windows Application Packaging" project doesn't play too nicely with multiple dynamic library components rolling up through a Win32 EXE (that doesn't support resw/resx) to make that happen easily. There's work here.

@DHowett-MSFT DHowett-MSFT mentioned this issue May 14, 2019
Closed
@DHowett-MSFT DHowett-MSFT changed the title Move hard-coded strings to resources Move hard-coded strings and UI text to Resources May 14, 2019
@miniksa miniksa added the Area-User Interface Issues pertaining to the user interface of the Console or Terminal label May 14, 2019
@miniksa miniksa added this to the Windows Terminal v1.0 milestone May 14, 2019
@zadjii-msft
Copy link
Member

Hey so for the record, the branch I have with the error dialog (dev/migrie/f/gh-error-dialog) does some of this. I just haven't gotten the UI tweaked exactly right to make this branch ready to PR quite yet.

@DHowett-MSFT DHowett-MSFT added the Product-Terminal The new Windows Terminal. label May 16, 2019
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@miniksa miniksa added Issue-Task It's a feature request, but it doesn't really need a major design. and removed Mass-Chaos labels May 17, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
DHowett-MSFT pushed a commit that referenced this issue Jul 14, 2019
@DHowett
Move TerminalApp's resources into the TerminalApp project
2a6e340 
This commit also introduces a scoped resource accessor, lightly taken
from microsoft-ui-xaml. It also moves all static UI strings out of
App.cpp and into localizable resources.

Fixes #792.
@DHowett-MSFT DHowett-MSFT mentioned this issue Jul 14, 2019
Merged
@ghost ghost added the In-PR This issue has a related PR label Jul 14, 2019
DHowett-MSFT pushed a commit that referenced this issue Jul 15, 2019
@DHowett
Move TerminalApp's resources into the TerminalApp project
de594c6 
This commit also introduces a scoped resource accessor, lightly taken
from microsoft-ui-xaml. It also moves all static UI strings out of
App.cpp and into localizable resources.

Fixes #792.
DHowett-MSFT pushed a commit that referenced this issue Jul 15, 2019
@DHowett
Move TerminalApp's resources into the TerminalApp project
e9127c9 
This commit also introduces a scoped resource accessor, lightly taken
from microsoft-ui-xaml. It also moves all static UI strings out of
App.cpp and into localizable resources.

Fixes #792.
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 23, 2019
DHowett-MSFT pushed a commit that referenced this issue Jul 23, 2019
@DHowett
Move TerminalApp's resources into the TerminalApp project (#1972)
69c67f8 
* Move TerminalApp's resources into the TerminalApp project

This commit also introduces a scoped resource accessor, lightly taken
from microsoft-ui-xaml. It also moves all static UI strings out of
App.cpp and into localizable resources.

Fixes #792.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Move TerminalApp's resources into the TerminalApp project microsoft/terminal
4 participants
@timheuer @DHowett-MSFT @miniksa @zadjii-msft