Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Settings drop down able to switch back to the json #9362

Closed
WSLUser opened this issue Mar 3, 2021 · 3 comments · Fixed by #17281
Closed

Make the Settings drop down able to switch back to the json #9362

WSLUser opened this issue Mar 3, 2021 · 3 comments · Fixed by #17281
Labels
Area-Settings Issues related to settings and customizability, for console or terminal In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone

Comments

@WSLUser
Copy link
Contributor

WSLUser commented Mar 3, 2021

Description of the new feature/enhancement

It appears the settings.json has become unbound and using the previous keybinding for it still opens the Settings UI. I can add a custom keybinding for the settings.json but I usually am lazy and simply click on the Settings drop down button as it's quicker and easier for me. So I'd like the ability to switch out the default experience for the Settings drop down.

Proposed technical implementation details (optional)

Add a global setting that allows the user to switch out the default experience. This should be able to be set from both the Settings UI and the settings.json.

@WSLUser WSLUser added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Mar 3, 2021
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 3, 2021
@DHowett
Copy link
Member

DHowett commented Mar 3, 2021

I don't hate this idea. @zadjii-msft -- i'd rather make this part of the "edit the menu to put ANY ACTION in it" arc though. WDYT?

@zadjii-msft
Copy link
Member

Yea, we should unify this with that effort. The spec for #1571 originally just had "we're gonna force [Settings, Feedback, About]" into the dropdown always. But now there are multiple possible "Settings" entries that make sense, so maybe those should be customizable too. Hmm. That might require a bit more noodling on, and an addendum to #1571 - New Tab Menu Customization.md

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Mar 3, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 3, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Mar 3, 2021
@WSLUser
Copy link
Contributor Author

WSLUser commented Mar 3, 2021

I agree that it should be considered part of that effort. I was just hoping to have something possibly in place for 1.8 and wasn't sure if a slightly different approach could be used while waiting for the New Tab Menu Customization. Alternatively, that would make a great 1.8 feature if possible (I'm sure everyone who uses custom keybindings and is told by the Settings UI to use the json would appreciate it too due to the format changes the UI does to the json).

@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 3, 2021
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, Backlog Jan 4, 2022
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Jun 6, 2024
github-merge-queue bot pushed a commit that referenced this issue Jun 6, 2024
Allows the user to define entries in the new tab menu that execute
actions, based on their action Id

Closes #3759
Closes #9362
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants