Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a script to publish a folder of binaries as a GH release #13629

Merged
merged 20 commits into from
Feb 26, 2024
Merged

Add a script to publish a folder of binaries as a GH release #13629

merged 20 commits into from
Feb 26, 2024

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Jul 29, 2022

This is a crazy fever dream.

I thought, "what if I could just have a script make all the releases, tags and names and upload all the assets to the right place?"

So, here's that script. Check it.

image

image

@github-actions

This comment has been minimized.

Sign in to view
@DHowett
Copy link
Member Author

DHowett commented Jul 29, 2022 •
edited
Loading

For fun, it can also be used to simply inspect a folder of releases:

% $rcs=.\Draft-TerminalReleases.ps1 ./115 -dumpoutput
% $rcs.Release | Format-Table

Name                     Branding TagVersion  DisplayVersion Branch       Assets
----                     -------- ----------  -------------- ------       ------
Windows Terminal          Release 1.14.1962.0 1.14.196       release-1.14 {Microsoft.WindowsTerminal, Microsoft.Window…
Windows Terminal Preview  Preview 1.15.2002.0 1.15.200       release-1.15 {Microsoft.WindowsTerminalPreview, Microsoft…

% $rcs.Release[0].Assets | Format-Table

Name                      Version                  Type Branding WindowsVersion Path
----                      -------                  ---- -------- -------------- ----
Microsoft.WindowsTerminal 1.14.1962.0 ApplicationBundle  Release 10.0.19041.0   C:\Users\duhowett\src\terminal\tools\R…
Microsoft.WindowsTerminal 1.14.1962.0     PreinstallKit  Release 10.0.19041.0   C:\Users\duhowett\src\terminal\tools\R…
Microsoft.WindowsTerminal 1.14.1963.0 ApplicationBundle  Release 10.0.22000.0   C:\Users\duhowett\src\terminal\tools\R…
Microsoft.WindowsTerminal 1.14.1963.0     PreinstallKit  Release 10.0.22000.0   C:\Users\duhowett\src\terminal\tools\R…

% $rcs.Release | ConvertTo-Json -Depth 5
[
  {
    "Name": "Windows Terminal",
    "Branding": 1,
    "TagVersion": {
      "Major": 1,
      "Minor": 14,
      "Build": 1962,
      "Revision": 0,
      "MajorRevision": 0,
      "MinorRevision": 0
    },
    "DisplayVersion": {
      "Major": 1,
      "Minor": 14,
      "Build": 196,
      "Revision": -1,
      "MajorRevision": -1,
      "MinorRevision": -1
    },

@github-actions

This comment has been minimized.

Sign in to view
@DHowett DHowett mentioned this pull request Jan 20, 2023
Closed
@DHowett
Copy link
Member Author

DHowett commented Jan 20, 2023

Consider renaming the preinstall kit to remove Windows10_ from it.

@DHowett
Merge remote-tracking branch 'origin/main' into dev/duhowett/oi-why-not-
612c779 
# Conflicts:
#	.github/actions/spelling/allow/allow.txt
#	.github/actions/spelling/expect/expect.txt
@DHowett
add hashes to the changelog?
700dcf2
@github-actions

This comment has been minimized.

Sign in to view
@DHowett
Copy link
Member Author

DHowett commented Jul 20, 2023

This is great and amazing, but it needs to be fixed for portable/zip builds and stuff too.

@DHowett DHowett closed this Jul 20, 2023
@DHowett DHowett reopened this Feb 26, 2024
@DHowett
Copy link
Member Author

DHowett commented Feb 26, 2024

Oh boy, is it ever ready to go

@DHowett DHowett changed the title WIP: Add a script to publish a folder of Terminal binaries as a release Add a script to publish a folder of Terminal binaries as a release Feb 26, 2024
@DHowett DHowett marked this pull request as ready for review February 26, 2024 19:45
zadjii-msft
zadjii-msft approved these changes Feb 26, 2024
View reviewed changes
tools/ReleaseEngineering/Draft-TerminalReleases.ps1
$this.Name = Switch($this.Branding) {
Release { "Windows Terminal" }
Preview { "Windows Terminal Preview" }
Default { throw "Unknown Branding for release publication $_" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Canary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard error if we try to publish Canary = OK with me. We should never publish one of those!

@DHowett DHowett changed the title Add a script to publish a folder of Terminal binaries as a release Add a script to publish a folder of binaries as a GH release Feb 26, 2024
@DHowett DHowett merged commit abf5d94 into main Feb 26, 2024
12 checks passed
@DHowett DHowett deleted the dev/duhowett/oi-why-not- branch February 26, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhecker lhecker lhecker approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DHowett @lhecker @zadjii-msft