Remove DxEngine #16278
Merged
Remove DxEngine #16278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Area-Rendering
lhecker
commented
Nov 7, 2023
lhecker
force-pushed
the
dev/lhecker/remove-dxengine
branch
2 times, most recently
from
4af3ccb
to
2ccc007
Compare
lhecker
force-pushed
the
dev/lhecker/remove-dxengine
branch
from
2ccc007
to
326b931
Compare
lhecker
commented
Jan 30, 2024
| bufferData = publicTerminal->_terminal->RetrieveSelectedTextFromBuffer(false, true, true); | ||
| const auto bufferData = publicTerminal->_terminal->RetrieveSelectedTextFromBuffer(false, true, true); | ||
| LOG_IF_FAILED(publicTerminal->_CopyTextToSystemClipboard(bufferData.plainText, bufferData.html, bufferData.rtf)); | ||
| publicTerminal->_ClearSelection(); |
There was a problem hiding this comment.
This fixes a bug which is noticeable in debug builds. _ClearSelection requires the lock being held, but in the old code it didn't do that.
DHowett
approved these changes
Feb 21, 2024
|
|
||
| using namespace Microsoft::Console::VirtualTerminal; | ||
| namespace Microsoft::Console::Render::Atlas |
There was a problem hiding this comment.
thank you so much for cleaning this up
| @@ -53,7 +53,7 @@ Settings::Settings() : | |||
| _fUseWindowSizePixels(false), | |||
| // window size pixels initialized below | |||
| _fInterceptCopyPaste(0), | |||
| _fUseDx(UseDx::Disabled), | |||
| _fUseDx(false), | |||
There was a problem hiding this comment.
lmao we will keep calling the setting usedx, i love it
|
LES FUCKIN' GO |
zadjii-msft
approved these changes
Feb 21, 2024
DHowett
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With AtlasEngine being fairly stable at this point and being enabled
by default in the 1.19 branch, this changeset removes DxEngine.
Validation Steps Performed
useAtlasEnginekey ✅