Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dark+, CGA and IBM color schemes #16953

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft commented Mar 27, 2024

As discussed in #6176 and #16754.

The "CGA" and "IBM 5153" names I'm told are the right ones to use: #16754 (comment)

Closes #6176
Closes #16754

@zadjii-msft
Copy link
Member Author

new-color-schemes

@DHowett
Copy link
Member

DHowett commented Mar 27, 2024

Qs:

Dark+

Does Dark+ not differentiate bright colors from dark colors? How should this work with bold=intense?

CGA, EGA, IBM, VBA, SiS S3

I know I am a heathen, but... I can't tell the difference between all these new schemes and, like, Vintange. And I am saying this as someone who has his own nearly identical scheme, URXVT: image

@zadjii-msft
Copy link
Member Author

Does Dark+ not differentiate bright colors from dark colors? How should this work with bold=intense?

color normal bright
black #000000 #666666
red #cd3131 #f14c4c
green #0dbc79 #23d18b
yellow #e5e510 #f5f543
blue #2472c8 #3b8eea
purple #bc3fbc #d670d6
cyan #11a8cd #29b8db
white #e5e5e5 #e5e5e5

those are literally different colors

@zadjii-msft
Copy link
Member Author

. I can't tell the difference between all these new schemes and, like, Vintange

From the thread:

image

CGA left, vintage right.

I'm a man of the people, but I also don't super care. Dark+ I think we definitely should add inbox (because it's the vscode scheme), but I'm also thinking that maybe we should just have a "schemes" extension we publish with everything lmao

@DHowett
Copy link
Member

DHowett commented Mar 28, 2024

those are literally different colors

Man, that is SUBTLE.

@DHowett DHowett enabled auto-merge March 28, 2024 12:17
@DHowett DHowett added this pull request to the merge queue Mar 28, 2024
Merged via the queue into main with commit 68955d1 Mar 28, 2024
20 checks passed
@DHowett DHowett deleted the dev/migrie/b/6176-new-color-schemes branch March 28, 2024 13:04
github-merge-queue bot pushed a commit that referenced this pull request Apr 2, 2024
…16962)

#16953 got me thinking: what if we just published an extension ourselves
that just packages up every color scheme in the ever-amazing
https:/mbadolato/iTerm2-Color-Schemes?

Well, this isn't a package for that file. 

But it is a script to generate a fragment with all of them, and blat it
into your `%LOCALAPPDATA%\Microsoft\Windows Terminal\Fragments`.

It's a notebook because I've been really fascinated with the Polyglot
Notebooks recently.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add color scheme for EGA (the "16 color ANSI" palette) Add Dark+
3 participants