Add input scope startup setting #17953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Task
DHowett
reviewed
Sep 24, 2024
| </ComboBox> | ||
| </local:SettingContainer> | ||
|
|
||
| <!-- Language --> |
There was a problem hiding this comment.
not language, but different
Suggested change
| <!-- Language --> | |
| <!-- Default Input Scope --> |
DHowett
reviewed
Sep 24, 2024
Comment on lines
+422
to
+423
| InterlockedDecrement(&referenceCount); | ||
| return self->Release(); |
There was a problem hiding this comment.
Mind explaining this change? I can't fully grok it.
There was a problem hiding this comment.
This ensures that self (aka parent aka the Implementation instance) stays alive for the duration of the request.
DHowett
approved these changes
Sep 24, 2024
carlos-zamora
approved these changes
Sep 24, 2024
DHowett
pushed a commit
that referenced
this pull request
Sep 26, 2024
This adds a "defaultInputScope" setting, hooks it up to our TSF, and exposes it as a setting in the UI under the startup page. In order to stay close with the other language setting, I moved that one from the appearance to the startup page as well. 20 out of the 26 files in this PR are boilerplate unfortunately. Closes #17816 * Install and use the Chinese IME * Launch WT * Chinese input ✅ * Change setting to `alphanumericHalfWidth` * Restart WT * English input ✅ (cherry picked from commit fc606d2) Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgTTKAE Service-Version: 1.21
DHowett
pushed a commit
that referenced
this pull request
Sep 26, 2024
This adds a "defaultInputScope" setting, hooks it up to our TSF, and exposes it as a setting in the UI under the startup page. In order to stay close with the other language setting, I moved that one from the appearance to the startup page as well. 20 out of the 26 files in this PR are boilerplate unfortunately. Closes #17816 ## Validation Steps Performed * Install and use the Chinese IME * Launch WT * Chinese input ✅ * Change setting to `alphanumericHalfWidth` * Restart WT * English input ✅ (cherry picked from commit fc606d2) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgTTKAI Service-Version: 1.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a "defaultInputScope" setting, hooks it up to our TSF,
and exposes it as a setting in the UI under the startup page.
In order to stay close with the other language setting, I moved that
one from the appearance to the startup page as well.
20 out of the 26 files in this PR are boilerplate unfortunately.
Closes #17816
Validation Steps Performed
alphanumericHalfWidth