Fix a couple of the DEC Special Graphics characters #2081
Conversation
…ode "black diamond suite", rather than the "black diamond", since the latter is currently rendered as a double width glyph.
…table to match the DEC documentation.
…the Special Graphics translation table.
|
@msftbot make sure @zadjii-msft signs off |
ghost
added
the
AutoMerge
|
Hello @DHowett-MSFT! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
|
Actually, nevermind. |
|
@msftbot forget everything I just told you |
|
Hello @DHowett-MSFT! Because you've told me to reset the custom auto-merge settings, I'll use the configured settings for this repository when I'm merging this pull request. |
|
🎉 Handy links: |
ghost
mentioned this pull request
|
This went out for conhost in insider build 19002! Thanks 😄 |
Summary of the Pull Request
Corrects the 0x5f code point in the DEC Special Graphics character set, which is meant to map to a blank glyph rather than an underscore. and updates the 0x60 code point to map to a "black diamond suite" glyph, rather than the "black diamond" glyph, since the latter currently renders as a double width character.
PR Checklist
Detailed Description of the Pull Request / Additional comments
The was mostly a matter of updating the
s_rgDECSpecialGraphicsTranslationstable in theTerminalOutputclass, but also required a change in theTranslateKeymethod, to make sure the 0x5f code point was included in the range of translatable characters.I've also made a few cosmetic changes to the source, fixing the comments on the translation table to match the DEC documentation (a couple of them were not quite right), and tidying up the case of the hex values in the table, so they're all consistently lowercase now.
The latter changes have been committed separately, so they're easy enough to revert if there are any objections to including them in this PR.
Validation Steps Performed
I've tested manually with Vttest's Test of character sets, making sure the two code points are mapped as expected, and the diamond glyph doesn't break the layout by being too wide.