Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If a profile did not have a GUID, generate one #2117

Merged
merged 1 commit into from
Jul 26, 2019
Merged

If a profile did not have a GUID, generate one #2117

merged 1 commit into from
Jul 26, 2019

Conversation

zadjii-msft
Copy link
Member

Summary of the Pull Request

If a profile did not have a GUID, generate one.

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

I ran the tests

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. labels Jul 26, 2019
@zadjii-msft zadjii-msft requested a review from a team July 26, 2019 13:58
carlos-zamora
carlos-zamora reviewed Jul 26, 2019
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add tests for the following?

  • GUID in different GUID format
  • completely invalid GUID (i.e.: guid = )
  • GUID with letters in caps

Or would the first two just be examples of invalid settings values anyways so there's no point?

src/cascadia/ut_app/JsonTests.cpp Show resolved Hide resolved
@zadjii-msft zadjii-msft merged commit 644ac56 into master Jul 26, 2019
@zadjii-msft zadjii-msft mentioned this pull request Jul 26, 2019
Closed
@zadjii-msft zadjii-msft deleted the dev/migrie/b/2108-rich-is-a-degenerate branch August 1, 2019 14:31
@ghost
Copy link

ghost commented Aug 3, 2019

🎉Windows Terminal Preview v0.3.2142.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Aug 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@DHowett-MSFT DHowett-MSFT DHowett-MSFT approved these changes

Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If a profile does not have a GUID, generate one for it
3 participants
@zadjii-msft @carlos-zamora @DHowett-MSFT