Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually check the elevation status when disabling tab rearrange #5542

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Actually check the elevation status when disabling tab rearrange #5542

merged 1 commit into from
Apr 27, 2020

Conversation

DHowett-MSFT
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT commented Apr 24, 2020 •
edited
Loading

This is, perhaps, silly.

Fixes #5564.

@DHowett-MSFT DHowett-MSFT mentioned this pull request Apr 24, 2020
Closed
zadjii-msft
zadjii-msft approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry 😢

@DHowett-MSFT DHowett-MSFT mentioned this pull request Apr 25, 2020
Closed
@zadjii-msft zadjii-msft added the Needs-Second It's a PR that needs another sign-off label Apr 27, 2020
@ghost ghost requested review from miniksa, carlos-zamora and leonMSFT April 27, 2020 13:58
miniksa
miniksa approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops.

@DHowett-MSFT DHowett-MSFT merged commit 8004223 into master Apr 27, 2020
DHowett-MSFT pushed a commit that referenced this pull request Apr 27, 2020
@DHowett
Actually check the elevation status when disabling tab rearrange (#5542)
58876dc 
Fixes #5564.
@ghost
Copy link

ghost commented Apr 28, 2020

🎉Windows Terminal Preview v0.11.1191.0 has been released which incorporates this pull request.:tada:

Handy links:

@DHowett-MSFT DHowett-MSFT deleted the dev/duhowett/elevate_crash_II branch May 2, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniksa miniksa miniksa approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

Assignees
No one assigned
Labels
Needs-Second It's a PR that needs another sign-off
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reordering tabs still crashes when running elevated
4 participants
@DHowett-MSFT @miniksa @zadjii-msft @DHowett