Remove the title tag from the generated HTML #5595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
changed the title
DHowett-MSFT
approved these changes
Apr 27, 2020
zadjii-msft
added
Product-Terminal
ghost
requested review from
|
Needs-build-fix |
|
I don't know if it's an issue, but maybe head should specify a charset (be it utf-8 or sth else?) |
carlos-zamora
approved these changes
Apr 29, 2020
|
admin merge: CI says code health passed. |
|
🎉 Handy links: |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Web apps apparently will paste the <title> as plaintext before the actual HTML content from the clipboard. Since this seems to be widespread behavior across web apps, this isn't just a bug in some app, this is a bug on us. We shouldn't emit the title.
This PR removes the title tag from the generated HTML.
PR Checklist
Validation Steps Performed
Above is composing an email with copied text from 0.11.
Below is using the same webmail client to compose an email with this patch