Improve default foregrounds for Tango schemes #5598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett-MSFT
approved these changes
Apr 27, 2020
|
Perhaps not, pure black on pure white always works, but for a lower contrast option we can use ansi 7 (white or gray) or ansi 8 (dark gray). I will test all 3 combinations and give you my impression. |
Followup on ea61aa3. The default foreground in the iTerm2 defaults for the Tango Dark color scheme is too bright, use the value for ANSI 7 (white) instead. Also use ANSI 8 (dark gray) as the foreground color for Tango Light, this looks nicer than ANSI 0 (black.) Signed-off-by: Rafael Kitover <[email protected]>
rkitover
force-pushed
the
tango-followup
branch
from
b4cb024
to
fdd30f3
Compare
|
I tested Tango Light with these 3 foreground values and I came to the conclusion that ANSI 8 (dark gray) looks best as the foreground color. It just looks nicer and more like you'd expect a black on white browser page to look like. I have updated the commit accordingly. |
zadjii-msft
approved these changes
Apr 27, 2020
zadjii-msft
added
Area-Settings
DHowett-MSFT
changed the title
|
Thank you. 😄 |
DHowett-MSFT
pushed a commit
that referenced
this pull request
Apr 27, 2020
Followup to ea61aa3. The default foreground in the iTerm2 defaults for the Tango Dark color scheme is too bright, use the value for ANSI 7 (white) instead. References #5305 Sorry, I should have really done this in the original PR. Signed-off-by: Rafael Kitover <[email protected]> (cherry picked from commit b4c9c0c)
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup on ea61aa3.
The default foreground in the iTerm2 defaults for the Tango Dark color
scheme is too bright, use the value for ANSI 7 (white) instead.
Signed-off-by: Rafael Kitover [email protected]
References
#5305
PR Checklist
Sorry, I should have really done this in the original PR.