-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable tab renaming at runtime from the UI #5775
Conversation
In my mind...
That said, consider the following scenario...
At this point, the title is "TITLE A". If I run |
Co-authored-by: Carlos Zamora <[email protected]>
Okay so the way I saw it was:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still disagree with you on the ESC thing, but I'd like to download the branch and try it out. So I'm not gonna block. Curious what other team members think about that behavior. @DHowett-MSFT Any chance we could get this in the next team selfhost build? 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it. More xaml files for UI would be good but not required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk why my machine won't let me actually download the branch and try it. But might as well put it in master and make changes after we get everybody testing it out.
@msftbot merge this bad boy in like 5 minutes |
Hello @zadjii-msft! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
LOL. |
about the discuss please trust the user, and make it as simple as possible
|
Hi guys, I'm really excited to start using this feature! I couldn't really find anything related to it, so I am asking here. Would it be possible to bind a shortcut key to the rename action, so that it open up the rename box once pressed? I quite often rename my windows once I repurposed them and would love not to have to take my hands of the keyboard. Let me know if I should create an issue for it. |
🎉 Handy links: |
Wow.. Congratulations team :D Apologies, I did not participate in #1079 after opening it up.. but I was following it closely. It gave me a great insights into how Microsoft plans features.. I have always trusted Microsoft.. but this process has given me kind of assurance that features are thought in details.. and with a quality in mind.. feature small as this one how it can be turned into a great feature is what this thread really teaches. |
Summary of the Pull Request
Adds support for setting, from the UI, a runtime override for the tab title text. The user can use this to effectively "rename" a tab.
If set, the tab will always use the runtime override string. If the user has multiple panes with different titles in a pane, then the tab's override text will be used regardless of which pane was focused when the tab was renamed.
The override text can be removed by just deleting the entire contents of the box. Then, the tab will revert to using the terminal's usual title.
References
PR Checklist
TODO
Tab::SetTabText
might be able to be greatly simplified/removed?title foo
, should the text change to "foo" or stay "cmd"?Detailed Description of the Pull Request / Additional comments