Implement drag-drop paste for text #5865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-TerminalControl
carlos-zamora
approved these changes
May 12, 2020
leonMSFT
approved these changes
May 12, 2020
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 6 hours 7 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
jelster
pushed a commit
to jelster/terminal
that referenced
this pull request
May 28, 2020
## Summary of the Pull Request Implements drag-dropping text onto a `TermControl`, in addition to the already supported drag-drop of files. ## References * [StandardDataFormats](https://docs.microsoft.com/en-us/uwp/api/windows.applicationmodel.datatransfer.standarddataformats?view=winrt-18362) * [StandardDataFormats::Text](https://docs.microsoft.com/en-us/uwp/api/windows.applicationmodel.datatransfer.standarddataformats.text?view=winrt-18362#Windows_ApplicationModel_DataTransfer_StandardDataFormats_Text) * [GetTextAsync](https://docs.microsoft.com/en-us/uwp/api/windows.applicationmodel.datatransfer.datapackageview.gettextasync?view=winrt-18362) ## PR Checklist * [x] Closes microsoft#5863 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments Oh I also changed "Copy path to file" to "Paste path to file". I thought that actually made more sense here ## Validation Steps Performed * Tested manually that text and files still work.
|
🎉 Handy links: |
ghost
mentioned this pull request
Closed
DHowett
pushed a commit
that referenced
this pull request
Jun 24, 2020
## Summary of the Pull Request Implements drag-dropping text onto a `TermControl`, in addition to the already supported drag-drop of files. ## References * [StandardDataFormats](https://docs.microsoft.com/en-us/uwp/api/windows.applicationmodel.datatransfer.standarddataformats?view=winrt-18362) * [StandardDataFormats::Text](https://docs.microsoft.com/en-us/uwp/api/windows.applicationmodel.datatransfer.standarddataformats.text?view=winrt-18362#Windows_ApplicationModel_DataTransfer_StandardDataFormats_Text) * [GetTextAsync](https://docs.microsoft.com/en-us/uwp/api/windows.applicationmodel.datatransfer.datapackageview.gettextasync?view=winrt-18362) ## PR Checklist * [x] Closes #5863 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments Oh I also changed "Copy path to file" to "Paste path to file". I thought that actually made more sense here ## Validation Steps Performed * Tested manually that text and files still work. (cherry picked from commit 88ed94d)
DHowett
pushed a commit
that referenced
this pull request
Jun 24, 2020
## Summary of the Pull Request Implements drag-dropping text onto a `TermControl`, in addition to the already supported drag-drop of files. ## References * [StandardDataFormats](https://docs.microsoft.com/en-us/uwp/api/windows.applicationmodel.datatransfer.standarddataformats?view=winrt-18362) * [StandardDataFormats::Text](https://docs.microsoft.com/en-us/uwp/api/windows.applicationmodel.datatransfer.standarddataformats.text?view=winrt-18362#Windows_ApplicationModel_DataTransfer_StandardDataFormats_Text) * [GetTextAsync](https://docs.microsoft.com/en-us/uwp/api/windows.applicationmodel.datatransfer.datapackageview.gettextasync?view=winrt-18362) ## PR Checklist * [x] Closes #5863 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments Oh I also changed "Copy path to file" to "Paste path to file". I thought that actually made more sense here ## Validation Steps Performed * Tested manually that text and files still work. (cherry picked from commit 88ed94d)
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Implements drag-dropping text onto a
TermControl, in addition to the already supported drag-drop of files.References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Oh I also changed "Copy path to file" to "Paste path to file". I thought that actually made more sense here
Validation Steps Performed