Correct the default 6x6x6 palette entries #5999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At some point we may want to generate this entire palette programmatically, but for now I just wanted to get a quick fix in place, because the discrepancy was bugging me. |
|
@msftbot merge this in 1 minute |
ghost
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit 
jelster
pushed a commit
to jelster/terminal
that referenced
this pull request
May 28, 2020
There is a range of 216 colors in the default 256-color table that is meant to be initialized with a 6x6x6 color cube, with each color component iterating over the values `00`, `5F`, `87`, `AF`, `D7`, and `FF`. A few of the entries incorrectly had the _red_ component has `DF`, when it should have been `D7`. This PR corrects those entries. It also removes a bit of unnecessary whitespace in the first 100 entries. ## Validation Steps Performed I have a visual test script that renders the full 256-color palette, using both the indexed color sequence (`SGR 38;5`) and the equivalent rgb representation (`SGR 38;2`) side by side. Although the difference was subtle when it was incorrect, I can now see that it has been fixed. Closes microsoft#5994
|
🎉 Handy links: |
ghost
mentioned this pull request
DHowett
pushed a commit
that referenced
this pull request
Jun 24, 2020
There is a range of 216 colors in the default 256-color table that is meant to be initialized with a 6x6x6 color cube, with each color component iterating over the values `00`, `5F`, `87`, `AF`, `D7`, and `FF`. A few of the entries incorrectly had the _red_ component has `DF`, when it should have been `D7`. This PR corrects those entries. It also removes a bit of unnecessary whitespace in the first 100 entries. ## Validation Steps Performed I have a visual test script that renders the full 256-color palette, using both the indexed color sequence (`SGR 38;5`) and the equivalent rgb representation (`SGR 38;2`) side by side. Although the difference was subtle when it was incorrect, I can now see that it has been fixed. Closes #5994 (cherry picked from commit 5d6fdf3)
DHowett
pushed a commit
that referenced
this pull request
Jun 24, 2020
There is a range of 216 colors in the default 256-color table that is meant to be initialized with a 6x6x6 color cube, with each color component iterating over the values `00`, `5F`, `87`, `AF`, `D7`, and `FF`. A few of the entries incorrectly had the _red_ component has `DF`, when it should have been `D7`. This PR corrects those entries. It also removes a bit of unnecessary whitespace in the first 100 entries. ## Validation Steps Performed I have a visual test script that renders the full 256-color palette, using both the indexed color sequence (`SGR 38;5`) and the equivalent rgb representation (`SGR 38;2`) side by side. Although the difference was subtle when it was incorrect, I can now see that it has been fixed. Closes #5994 (cherry picked from commit 5d6fdf3)
|
🎉 Handy links: |
|
🎉 Once again, thanks for the contribution! This pull request was included in a set of conhost changes that was just |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a range of 216 colors in the default 256-color table that is
meant to be initialized with a 6x6x6 color cube, with each color
component iterating over the values
00,5F,87,AF,D7, andFF. A few of the entries incorrectly had the red component hasDF,when it should have been
D7. This PR corrects those entries. It alsoremoves a bit of unnecessary whitespace in the first 100 entries.
Validation Steps Performed
I have a visual test script that renders the full 256-color palette,
using both the indexed color sequence (
SGR 38;5) and the equivalentrgb representation (
SGR 38;2) side by side. Although the differencewas subtle when it was incorrect, I can now see that it has been fixed.
Closes #5994